Skip to content

Replace GetDirectories in HelpFileHelpProvider#15167

Merged
iSazonov merged 1 commit into
PowerShell:masterfrom
xtqqczze:getfiles-HelpFileHelpProvider
Apr 15, 2021
Merged

Replace GetDirectories in HelpFileHelpProvider#15167
iSazonov merged 1 commit into
PowerShell:masterfrom
xtqqczze:getfiles-HelpFileHelpProvider

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Apr 6, 2021

Avoid array allocations from GetDirectories/GetFiles.

Contributes to #14318.

@ghost ghost assigned iSazonov Apr 6, 2021
@xtqqczze xtqqczze closed this Apr 6, 2021
@xtqqczze xtqqczze reopened this Apr 6, 2021
Comment thread src/System.Management.Automation/help/HelpFileHelpProvider.cs
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Apr 6, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Apr 14, 2021
@ghost
Copy link
Copy Markdown

ghost commented Apr 14, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Copy Markdown
Contributor Author

@iSazonov Shall I replace Linq Where with if statement?

@iSazonov
Copy link
Copy Markdown
Collaborator

No. If @adityapatwardhan agree I will merge.

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 14, 2021
Comment thread src/System.Management.Automation/help/HelpFileHelpProvider.cs
@iSazonov iSazonov merged commit 4e073fd into PowerShell:master Apr 15, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.6 milestone Apr 15, 2021
@xtqqczze xtqqczze deleted the getfiles-HelpFileHelpProvider branch April 15, 2021 14:49
@ghost
Copy link
Copy Markdown

ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants