Skip to content

DO NOT MERGE: 7.2.0-preview.2 changes#14434

Merged
rjmholt merged 4 commits into
PowerShell:masterfrom
rjmholt:changesfrom-v7.2.0-preview.2
Dec 16, 2020
Merged

DO NOT MERGE: 7.2.0-preview.2 changes#14434
rjmholt merged 4 commits into
PowerShell:masterfrom
rjmholt:changesfrom-v7.2.0-preview.2

Conversation

@rjmholt

@rjmholt rjmholt commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Changes made for the 7.2.0-preview.2 release.

PR Context

PR Checklist

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling file needs to be updated to fix the static analysis CI.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 16, 2020
@rjmholt

rjmholt commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator Author

@daxian-dbw note that I've removed a commit rather than added a reversion commit. I can add the commit and its reversion if that's preferred.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 16, 2020
@rjmholt rjmholt requested a review from daxian-dbw December 16, 2020 05:40
@rjmholt

rjmholt commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator Author

Spelling file needs to be updated to fix the static analysis CI.

Done

@rjmholt

rjmholt commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator Author

See #14437 for the CI fix required to make CI pass for this

@PaulHigin PaulHigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit 4ac1663 into PowerShell:master Dec 16, 2020
@rjmholt rjmholt deleted the changesfrom-v7.2.0-preview.2 branch December 16, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants