Skip to content

Enable nullable: System.Management.Automation.Language.ICustomAstVisitor#14191

Merged
iSazonov merged 4 commits into
PowerShell:masterfrom
powercode:nullable/ICustomAstVisitor
May 19, 2021
Merged

Enable nullable: System.Management.Automation.Language.ICustomAstVisitor#14191
iSazonov merged 4 commits into
PowerShell:masterfrom
powercode:nullable/ICustomAstVisitor

Conversation

@powercode
Copy link
Copy Markdown
Collaborator

Tracking issue: #12631.

@ghost ghost assigned iSazonov Nov 20, 2020
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only please move the directive.

Comment on lines 205 to +207

#nullable restore

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#nullable restore
#nullable restore

Comment thread src/System.Management.Automation/engine/parser/AstVisitor.cs Outdated
Comment thread src/System.Management.Automation/engine/parser/AstVisitor.cs
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@iSazonov
Copy link
Copy Markdown
Collaborator

@powercode Please add the standard XML comment like "This never returns null." to appropriate methods.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 29, 2020
@ghost
Copy link
Copy Markdown

ghost commented Nov 29, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov requested a review from rjmholt December 11, 2020 05:15
Copy link
Copy Markdown
Collaborator

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powercode Please add the standard XML comment like "This never returns null." to appropriate methods.

Blocked on this

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Dec 11, 2020
@ghost ghost added the Stale label Dec 30, 2020
@ghost
Copy link
Copy Markdown

ghost commented Dec 30, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Jan 10, 2021
@iSazonov iSazonov reopened this Jan 10, 2021
@ghost ghost closed this Jan 20, 2021
@iSazonov iSazonov reopened this May 18, 2021
@iSazonov iSazonov removed the Stale label May 18, 2021
@iSazonov iSazonov removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 19, 2021
@iSazonov iSazonov merged commit 91b2904 into PowerShell:master May 19, 2021
@powercode powercode deleted the nullable/ICustomAstVisitor branch May 25, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants