Skip to content

Enable nullable: System.Management.Automation.Tracing.IEtwActivityReverter#14154

Merged
iSazonov merged 2 commits into
PowerShell:masterfrom
powercode:nullable/IEtwActivityReverter
Jan 9, 2021
Merged

Enable nullable: System.Management.Automation.Tracing.IEtwActivityReverter#14154
iSazonov merged 2 commits into
PowerShell:masterfrom
powercode:nullable/IEtwActivityReverter

Conversation

@powercode
Copy link
Copy Markdown
Collaborator

Tracking issue: #12631.

@ghost ghost assigned iSazonov Nov 19, 2020
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude internal class EtwActivityReverter - a rule is one type per PR.
Also the class should be refactored before annotating (constructor don't check input arguments).

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 29, 2020
@ghost
Copy link
Copy Markdown

ghost commented Nov 29, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov merged commit 4c8df5c into PowerShell:master Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 9, 2021
@powercode powercode deleted the nullable/IEtwActivityReverter branch January 13, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants