Skip to content

change nullable usage#13849

Merged
adityapatwardhan merged 1 commit into
PowerShell:masterfrom
bcwood:fix-ExternalScriptInfo
Apr 19, 2021
Merged

change nullable usage#13849
adityapatwardhan merged 1 commit into
PowerShell:masterfrom
bcwood:fix-ExternalScriptInfo

Conversation

@bcwood
Copy link
Copy Markdown
Contributor

@bcwood bcwood commented Oct 22, 2020

PR Summary

Change nullable usage

PR Context

related to #13791

PR Checklist

ghost
ghost suggested changes Oct 23, 2020
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again Check It I Dont Understand

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 23, 2020
@bcwood
Copy link
Copy Markdown
Contributor Author

bcwood commented Oct 23, 2020

@myself786 I'm attempting to clean up the Nullable.HasValue usages, as described in #13791

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 23, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 31, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 31, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan merged commit 4d702e0 into PowerShell:master Apr 19, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 19, 2021
rkeithhill pushed a commit to rkeithhill/PowerShell that referenced this pull request May 3, 2021
@bcwood @rkeithhill
Use GetValueOrDefault() for nullable PSLanguageMode (PowerShell#1…
ca4b032 
…3849)
@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 26, 2021
@ghost
Copy link
Copy Markdown

ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Aug 23, 2021

This PR introduced a change in logic. Since FullLanguage is the default value for PSLanguageMode we no longer distinguish between the default value and no value.

@adityapatwardhan @iSazonov We should revert this?

@xtqqczze xtqqczze mentioned this pull request Aug 23, 2021
Closed
@adityapatwardhan
Copy link
Copy Markdown
Member

adityapatwardhan commented Aug 23, 2021

@PaulHigin and @TravisEz13 .. could you please review if a revert is needed?

@PaulHigin
Copy link
Copy Markdown
Contributor

PaulHigin commented Aug 23, 2021

Yes, this must be reverted. The logic depends on whether a variable has been defined or not.

adityapatwardhan added a commit that referenced this pull request Aug 23, 2021
@adityapatwardhan
Revert "Use GetValueOrDefault() for nullable PSLanguageMode (#13849…
f2efe92 
…)"

This reverts commit 4d702e0.
@adityapatwardhan adityapatwardhan mentioned this pull request Aug 23, 2021
Merged
daxian-dbw pushed a commit that referenced this pull request Aug 24, 2021
@adityapatwardhan
Revert "Use GetValueOrDefault() for nullable PSLanguageMode (#13849…
ab5e177 
…)" (#15980)
@xtqqczze xtqqczze mentioned this pull request Aug 28, 2021
Merged
xtqqczze pushed a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Sep 2, 2021
@adityapatwardhan @xtqqczze
Revert "Use GetValueOrDefault() for nullable PSLanguageMode (Powe…
4444053 
…rShell#13849)" (PowerShell#15980)
@daxian-dbw daxian-dbw added this to the 7.2.0-rc.1 milestone Sep 7, 2021
TravisEz13 pushed a commit that referenced this pull request Sep 29, 2021
@adityapatwardhan
Revert "Use GetValueOrDefault() for nullable PSLanguageMode (#13849…
d3465ab 
…)" (#15980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

Backport-7.2.x-Done CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.10

Development

Successfully merging this pull request may close these issues.

5 participants

@bcwood @xtqqczze @adityapatwardhan @PaulHigin @daxian-dbw