Fix ConciseView for interactive advanced function writing error#13623
Merged
Conversation
08a46c7 to
18a9794
Compare
Collaborator
|
looks like this is a fix for #12727 |
Member
Author
|
Thanks @kilasuit! |
iSazonov
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In the case where you interactively write to the console an advanced function that writes an error, that error doesn't get rendered. This is because in the ConciseView formatting, it doesn't correctly check if InvocationInfo.MyCommand.Name exists so it tries to find a command called $Null which fails.
Fix is to add check that InvocationInfo.MyCommand.Name exists.
PR Context
Fix #12727
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.