Skip to content

Recognize CONOUT$ and CONIN$ as reserved device names #13508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 3 commits into from
Sep 14, 2020
Merged

Recognize CONOUT$ and CONIN$ as reserved device names #13508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff25b97
Detect CONIN$ and CONOUT$ as reserved names in Win
davidreis97 Aug 23, 2020
ee101c3
Change max length of filenames checked as reserved
davidreis97 Aug 23, 2020
e75773f
Add CONIN$, CONOUT$ to reserved names Pester test
davidreis97 Aug 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/System.Management.Automation/engine/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,14 +1258,14 @@ internal static bool IsAdministrator()
internal static bool IsReservedDeviceName(string destinationPath)
{
#if !UNIX
string[] reservedDeviceNames = { "CON", "PRN", "AUX", "CLOCK$", "NUL",
string[] reservedDeviceNames = { "CON", "PRN", "AUX", "CLOCK$", "NUL", "CONIN$", "CONOUT$",
"COM0", "COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
"LPT0", "LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9" };
string compareName = Path.GetFileName(destinationPath);
string noExtensionCompareName = Path.GetFileNameWithoutExtension(destinationPath);

if (((compareName.Length < 3) || (compareName.Length > 6)) &&
((noExtensionCompareName.Length < 3) || (noExtensionCompareName.Length > 6)))
if (((compareName.Length < 3) || (compareName.Length > 7)) &&
((noExtensionCompareName.Length < 3) || (noExtensionCompareName.Length > 7)))
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not blocking. It looks to me we only need to check on noExtensionCompareName. The checking on compareName seems not needed. /cc @anmenaga @iSazonov

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I open new tracking issue #13618.

{
return false;
}
Expand Down
2 changes: 2 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Describe "Basic FileSystem Provider Tests" -Tags "CI" {
@{ deviceName = 'AUX' }
@{ deviceName = 'CLOCK$' }
@{ deviceName = 'NUL' }
@{ deviceName = 'CONIN$' }
@{ deviceName = 'CONOUT$' }
@{ deviceName = 'COM0' }
@{ deviceName = 'COM1' }
@{ deviceName = 'COM2' }
Expand Down