Skip to content

Turn on /features:strict for all projects - #13383

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
xtqqczze:features-strict
Oct 23, 2020
Merged

Turn on /features:strict for all projects#13383
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
xtqqczze:features-strict

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Follow-up: #13285

For example, with strict mode enabled, the following is an error:

IntPtr ptr = IntPtr.Zero;
if (ptr == null) // Warning CS8073 The result of the expression is always 'false' since a value of type 'IntPtr' is never equal to 'null' of type 'IntPtr?'

PR Context

PR Checklist

@xtqqczze
xtqqczze force-pushed the features-strict branch 2 times, most recently from 07df421 to 86ff7da Compare August 8, 2020 23:52
@xtqqczze xtqqczze changed the title WIP: Use C# strict mode Use C# strict mode Aug 9, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review August 9, 2020 22:57
@xtqqczze
xtqqczze marked this pull request as draft August 9, 2020 22:57
@xtqqczze
xtqqczze marked this pull request as ready for review August 10, 2020 23:11
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 19, 2020
@ghost

Deleted user (ghost) commented Aug 19, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 Travis Plunk (TravisEz13) added Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers and removed Review - Needed The PR is being reviewed labels Aug 19, 2020
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 19, 2020

Copy link
Copy Markdown
Member

I recommend that the maintainers review if we want this setting.

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 27, 2020
@ghost

Deleted user (ghost) commented Aug 27, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 1, 2020

Copy link
Copy Markdown
Member

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it, but the changes should be made in powershell.common.props instead.

@ghost ghost removed the Review - Needed The PR is being reviewed label Sep 1, 2020
@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020
@xtqqczze

xtqqczze commented Sep 5, 2020

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) powershell.common.props is not included in all projects, e.g. xUnit.test Using Directory.Build.props propgates the property to any existing or new projects in repository.

@TravisEz13

Travis Plunk (TravisEz13) commented Sep 9, 2020

Copy link
Copy Markdown
Member

add it to xUnit separately if you want it there.

@ghost ghost added the Review - Needed The PR is being reviewed label Sep 17, 2020
@ghost

Deleted user (ghost) commented Sep 17, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 Travis Plunk (TravisEz13) added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Oct 2, 2020
@ghost ghost added the Stale label Oct 17, 2020
@ghost

Deleted user (ghost) commented Oct 17, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@xtqqczze xtqqczze changed the title Use C# strict mode Turn on /features:strict for all projects Oct 22, 2020
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Oct 22, 2020
@TravisEz13 Travis Plunk (TravisEz13) changed the title Turn on /features:strict for all projects Turn on /features:strict for all projects Oct 23, 2020
@TravisEz13
Travis Plunk (TravisEz13) merged commit ebff402 into PowerShell:master Oct 23, 2020
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 23, 2020
@xtqqczze
xtqqczze deleted the features-strict branch October 23, 2020 19:35
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Turn on /features:strict for all projects (PowerShell#13383)
21be7f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @TravisEz13 @daxian-dbw