Skip to content

Use is not syntax part 2 - #13338

Merged
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
xtqqczze:isnot2
Nov 5, 2020
Merged

Use is not syntax part 2#13338
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
xtqqczze:isnot2

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 2, 2020

Copy link
Copy Markdown
Contributor

PR Summary

  • More !(foo is T) -> foo is not T
  • Convert boolean logic to DNF form

PR Context

Follow-up #13323

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 3, 2020
Comment thread src/System.Management.Automation/DscSupport/CimDSCParser.cs Outdated
Comment thread src/System.Management.Automation/engine/GetCommandCommand.cs Outdated
Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Outdated
Comment thread src/System.Management.Automation/engine/hostifaces/Connection.cs Outdated
Comment thread src/System.Management.Automation/engine/hostifaces/pipelinebase.cs Outdated
Comment thread src/System.Management.Automation/engine/parser/Parser.cs Outdated
Comment thread src/System.Management.Automation/engine/parser/SemanticChecks.cs Outdated
Comment thread src/System.Management.Automation/engine/parser/SemanticChecks.cs Outdated
Comment thread src/System.Management.Automation/engine/parser/SemanticChecks.cs Outdated
Comment thread src/System.Management.Automation/engine/parser/SemanticChecks.cs Outdated
Comment thread src/System.Management.Automation/engine/parser/SemanticChecks.cs Outdated
Comment thread src/System.Management.Automation/engine/runtime/Binding/Binders.cs Outdated
Comment thread src/System.Management.Automation/engine/runtime/Binding/Binders.cs Outdated
Comment thread src/System.Management.Automation/engine/runtime/Binding/Binders.cs Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Mark it for maintainers to review.

@daxian-dbw Dongbo Wang (daxian-dbw) added the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Aug 5, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 19, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Andrew (@anmenaga) Can you please review?

@anmenaga

Copy link
Copy Markdown

xtqqczze Yup; it was marked for Review - Maintainer; we'll take a look at it.

@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Sep 30, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Please reopen.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Oct 13, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Oct 13, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

Andrew (@anmenaga) Dongbo Wang (@daxian-dbw) Can we merge to 7.2 Preview1?

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 16, 2020
xtqqczze and others added 6 commits October 23, 2020 15:45
-replace '!\(([^&|]+?) is ([^&|]+?)\)', '$1 is not $2'
Co-authored-by: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
@xtqqczze
xtqqczze marked this pull request as ready for review October 23, 2020 14:46
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 23, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

rebased

@xtqqczze xtqqczze mentioned this pull request Oct 26, 2020
14 tasks
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 31, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov
Ilya (iSazonov) merged commit 03a58c4 into PowerShell:master Nov 5, 2020
@xtqqczze
xtqqczze deleted the isnot2 branch November 5, 2020 16:18
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants