Does not re-evaluate home dir path#13218
Closed
iSazonov wants to merge 2 commits into
Closed
Conversation
7a3e867 to
bb282f1
Compare
Member
|
Sorry that I didn't notice this PR before submitting #13239 😦 |
daxian-dbw
reviewed
Jul 23, 2020
| // Cache the path so that GetTemporaryDirectory() does not create | ||
| // a temp directory for every new runspace if HOME environment variable is not present or empty. | ||
| private static string s_envHome = | ||
| System.Environment.GetEnvironmentVariable(CommonEnvVariableNames.Home) ?? GetTemporaryDirectory(); |
Member
There was a problem hiding this comment.
If we cache HOME, then why not cache other values read from environment variables like XDG_CONFIG_HOME? Also we don't cache the "MyDocument" path on Windows. I think just caching a temp directory path on the first use would be sufficient.
Collaborator
Author
There was a problem hiding this comment.
It seems it is not on hot path, I do not think we get a win.
Do we continue your PR or the PR? :-)
Member
There was a problem hiding this comment.
My PR already did that and it's only 2 lines change 😄 How about just close this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #13189.
Internally cache a home directory path on Unix so that does not re-valuate the value and does not re-create temporary home directory every time if HOME environment variable is empty or absent.
(No tests was added because it is an edge case and we need a test hook for reliable test.)
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.