Skip to content

Fix NRE in Test-Json - #12942

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
iSazonov:nre-test-json
Oct 27, 2020
Merged

Fix NRE in Test-Json#12942
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
iSazonov:nre-test-json

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Jun 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Add null check.

PR Context

The issue was discovered while nullable annotating in #11397 but I believe the bug should be fixed in separate commit.

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jun 11, 2020
TravisEz13
Travis Plunk (TravisEz13) previously requested changes Jun 14, 2020
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider suggestion and rebase

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 14, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 15, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 22, 2020
@ghost

Deleted user (ghost) commented Jun 22, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@TravisEz13

Travis Plunk (TravisEz13) commented Jun 22, 2020

Copy link
Copy Markdown
Member

/azp run

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 22, 2020
@TravisEz13

Travis Plunk (TravisEz13) commented Jun 22, 2020

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) Please remind me 1 day

@azure-pipelines

azure-pipelines Bot commented Jun 22, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@PoshChan

PoshChan-Bot (PoshChan) commented Jun 22, 2020

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13), I do not understand: Please remind me 1 day

Commands available in this repo for you:
  • retry <target> this will attempt to retry only the failed jobs for the target pipeline, restart can be used in place of retry
  • rebuild <target> this will perform a complete rebuild of the target pipeline, rerun can be used in place of rebuild Supported values for <target> which can be a comma separated list are: static,windows,macos,linux,ssh,all
  • get failures this will attempt to get the latest failures for all of the target pipelines
  • remind me in <value> <units> this will create a reminder that will be posted after the specified duration <value> is a number, and <units> can be minutes, hours, or days (singular or plural)

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 30, 2020
@ghost

Deleted user (ghost) commented Jun 30, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov

Ilya (iSazonov) commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) Can you merge the PR?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 1, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jul 8, 2020
@ghost

Deleted user (ghost) commented Jul 8, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov

Ilya (iSazonov) commented Aug 7, 2020

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) Friendly ping.

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 7, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 14, 2020
@ghost

Deleted user (ghost) commented Aug 14, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 Travis Plunk (TravisEz13) removed the Review - Needed The PR is being reviewed label Aug 14, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 23, 2020
@ghost

Deleted user (ghost) commented Aug 23, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13
Travis Plunk (TravisEz13) merged commit dfc591c into PowerShell:master Oct 27, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 27, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Oct 28, 2020
@iSazonov
Ilya (iSazonov) deleted the nre-test-json branch October 28, 2020 04:39
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov
Fix NRE in Test-Json (PowerShell#12942)
aa0eb44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @TravisEz13 @PoshChan @daxian-dbw