Skip to content

Add HoloLens to list of PowerShell adopters - #12940

Merged
Ilya (iSazonov) merged 4 commits into
PowerShell:masterfrom
reynoldsbd:hololens-adopter
Jun 17, 2020
Merged

Add HoloLens to list of PowerShell adopters#12940
Ilya (iSazonov) merged 4 commits into
PowerShell:masterfrom
reynoldsbd:hololens-adopter

Conversation

@reynoldsbd

@reynoldsbd Bobby Reynolds (reynoldsbd) commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

Summary

Add information to ADOPTERS.md describing how PowerShell is used for Microsoft HoloLens development.

Checklist

@ghost ghost assigned Ilya (iSazonov) Jun 10, 2020
@iSazonov Ilya (iSazonov) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 11, 2020
iSazonov
Ilya (iSazonov) reviewed Jun 11, 2020
View reviewed changes
Comment thread ADOPTERS.md Outdated
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jun 11, 2020
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs should not contain the locale as it's detected by the website. Also suggest calling out PS7 specifically since HoloLens dependency is specifically PS7+

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 11, 2020
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jun 11, 2020
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to add the word HoloLens to our spelling dictionary right before this line: https://github.com/PowerShell/PowerShell/blob/master/.spelling#L336

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 11, 2020
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 11, 2020

Copy link
Copy Markdown
Member

CI failure is due to #12935 and isn't blocking for this PR.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 16, 2020

Copy link
Copy Markdown
Member

Ilya (@iSazonov) I think we're good to merge this one

@iSazonov

Ilya (iSazonov) commented Jun 16, 2020

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) I haven't permissions to force the merging. So waiting CI-macos resolving.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 17, 2020

Copy link
Copy Markdown
Member

Ilya (@iSazonov) ok, I rebased this branch and that should pass CI

@iSazonov
Ilya (iSazonov) merged commit a3319d7 into PowerShell:master Jun 17, 2020
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.4 milestone Jun 17, 2020
@ghost

Deleted user (ghost) commented Jun 25, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@reynoldsbd
Add HoloLens to list of PowerShell adopters (PowerShell#12940)
91e0b5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.4

Development

Successfully merging this pull request may close these issues.

3 participants

@reynoldsbd @SteveL-MSFT @iSazonov