Skip to content

Make Parameters property of CommandInfo thread safe #12865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Christoph Bergmeister (bergmeister) wants to merge 1 commit into from
Closed

Make Parameters property of CommandInfo thread safe #12865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/System.Management.Automation/engine/MergedCommandParameterMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation.
Comment thread
bergmeister marked this conversation as resolved.
Comment thread
bergmeister marked this conversation as resolved.
Comment thread
bergmeister marked this conversation as resolved.
// Licensed under the MIT License.

using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Globalization;
Expand Down Expand Up @@ -604,7 +605,7 @@ internal Collection<MergedCompiledCommandParameter> GetParametersInParameterSet(
internal IDictionary<string, MergedCompiledCommandParameter> BindableParameters { get { return _bindableParameters; } }

private IDictionary<string, MergedCompiledCommandParameter> _bindableParameters =
new Dictionary<string, MergedCompiledCommandParameter>(StringComparer.OrdinalIgnoreCase);
new ConcurrentDictionary<string, MergedCompiledCommandParameter>(StringComparer.OrdinalIgnoreCase);

/// <summary>
/// Gets a dictionary of the parameters that have been aliased to other names. The key is
Expand Down