Skip to content

Expand numberOfPowershellRefAssemblies list capacity - #12840

Merged
4 commits merged into
PowerShell:masterfrom
xtqqczze:Fix-GH12815
Jun 2, 2020
Merged

Expand numberOfPowershellRefAssemblies list capacity#12840
4 commits merged into
PowerShell:masterfrom
xtqqczze:Fix-GH12815

Conversation

@xtqqczze

@xtqqczze xtqqczze commented May 29, 2020

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

HEAD of master has been broken since 99da109 (#12772), when .NET was updated to 5.0.100-preview.5.20278.13

#12815 (comment)

PR Checklist

@adityapatwardhan

Copy link
Copy Markdown
Member

xtqqczze Please use a more descriptive PR title.

@xtqqczze xtqqczze changed the title Fix GH12815 WIP: Fix GH12815 May 29, 2020
@xtqqczze xtqqczze changed the title WIP: Fix GH12815 Expand numberOfPowershellRefAssemblies list capacity May 29, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

This resolves the issue in #12815 (comment) but does not fix #12815 as it does not include a static test.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) can you help merge to resolve the breakage described in #12815 (comment)

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 31, 2020
@vexx32

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) and Aditya Patwardhan (@adityapatwardhan) probably best to get this merged sooner than later; folks can't currently run debug builds at all while this is an issue.

@xtqqczze

xtqqczze commented Jun 1, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) since you merged #12520, which this PR partially reverts, can you help merge this PR?

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs Outdated
@TravisEz13 Travis Plunk (TravisEz13) added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 1, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 1, 2020
@xtqqczze

xtqqczze commented Jun 1, 2020

Copy link
Copy Markdown
Contributor Author

The capacity is now 161 as per Ilya (@iSazonov) suggestion.

@xtqqczze

xtqqczze commented Jun 1, 2020

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) ready to merge?

@iSazonov Ilya (iSazonov) added the AutoMerge informs the bot to automerge the PR label Jun 2, 2020
@ghost

Copy link
Copy Markdown

Hello Ilya (@iSazonov)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
ghost merged commit 8f7d308 into PowerShell:master Jun 2, 2020
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.4 milestone Jun 2, 2020
@xtqqczze
xtqqczze deleted the Fix-GH12815 branch June 2, 2020 11:31
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
# PR Summary

* Increase the list capacity because .NET v5.0.100-preview.5.20278.13 has an extra assembly
* Remove assert added in PowerShell#12520

## PR Context

HEAD of master has been broken since d5f46ec (PowerShell#12772), when .NET was updated to 5.0.100-preview.5.20278.13

PowerShell#12815 (comment)

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
    - [x] None
    - **OR**
    - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
        - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
    - [x] N/A or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
    - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    - **OR**
    - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
        - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
        - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
        - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge informs the bot to automerge the PR CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants