Skip to content

Remove use of Test-Path in ConciseView - #12778

Merged
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
SteveL-MSFT:errorview-autoloading
Jun 11, 2020
Merged

Remove use of Test-Path in ConciseView#12778
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
SteveL-MSFT:errorview-autoloading

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented May 25, 2020

Copy link
Copy Markdown
Member

PR Summary

Both ConciseView and Get-Error used Test-Path which wouldn't be available if $PSModuleAutoLoadingPreference is set to none. Fix is to simply check against $null instead of using that cmdlet.

PR Context

Fix #12671

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 25, 2020
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.4 milestone May 25, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Please look CI failures.

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 3, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@iSazonov

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Could you please fix CIs?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 3, 2020
@iSazonov Ilya (iSazonov) added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 3, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 5, 2020
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the errorview-autoloading branch 3 times, most recently from 909424e to 2f04318 Compare June 5, 2020 23:18
Comment thread 1 Outdated
Comment thread test/powershell/engine/Formatting/ErrorView.Tests.ps1 Outdated
Comment thread test/powershell/engine/Formatting/ErrorView.Tests.ps1 Outdated
@iSazonov Ilya (iSazonov) added the AutoMerge informs the bot to automerge the PR label Jun 6, 2020
@ghost

Copy link
Copy Markdown

Hello Ilya (@iSazonov)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@iSazonov Ilya (iSazonov) removed the AutoMerge informs the bot to automerge the PR label Jun 11, 2020
@iSazonov
Ilya (iSazonov) merged commit ec20043 into PowerShell:master Jun 11, 2020
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$ErrorView = "ConciseView" does not print any errors with module autoloading disabled

4 participants