IDictionary -> IDictionary<string, FunctionInfo> for FunctionTable - #12658
Conversation
f63aa7f to
6667d89
Compare
Rain Sallow (/u/ta11ow) (vexx32)
left a comment
There was a problem hiding this comment.
Looks good to me! 🙂
| WildcardOptions.IgnoreCase); | ||
|
|
||
| foreach (DictionaryEntry functionEntry in _context.EngineSessionState.GetFunctionTable()) | ||
| foreach (var functionEntry in _context.EngineSessionState.GetFunctionTable()) |
There was a problem hiding this comment.
The type is not obvious. Please replace var with explicit type.
There was a problem hiding this comment.
Maybe
ExecutionContext context = _context;
SessionStateInternal sessionState = context.EngineSessionState;
IDictionary<string, FunctionInfo> functionTable = sessionState.GetFunctionTable();
foreach (KeyValuePair<string, FunctionInfo> functionEntry in functionTable)
{
...The types are not obvious in _context.EngineSessionState.GetFunctionTable() either...
There was a problem hiding this comment.
_context.EngineSessionState is common pattern in Engine. .For the small refactor I thing it makes sense only replace var with type.
|
Codacy is just wrong here, by the way. |
|
Hello Ilya (@iSazonov)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
…owerShell#12658) <!-- Anything that looks like this is a comment and can't be seen after the Pull Request is created. --> # PR Summary Typed return value for SessionStateInternal.GetFunctionTable. IDictionary<string, FunctionInfo> instead of IDictionary. ## PR Context Removes unnecessary casts, and helps with later nullablility changes. ## PR Checklist - [ ] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - Use the present tense and imperative mood when describing your changes - [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready. - **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)** - [x] None - **OR** - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md) - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here --> - **User-facing changes** - [x] Not Applicable - **OR** - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] Issue filed: <!-- Number/link of that issue here --> - **Testing - New and feature** - [ ] N/A or can only be tested interactively - **OR** - [x] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting) - **Tooling** - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. - **OR** - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host). - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions). - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
PR Summary
Typed return value for SessionStateInternal.GetFunctionTable.
IDictionary<string, FunctionInfo> instead of IDictionary.
PR Context
Removes unnecessary casts, and helps with later nullablility changes.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.