Skip to content

Address Set-Location/Get-Item Issue With ?/* Characters #12294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bryan Berns (NoMoreFood) wants to merge 4 commits into from
Closed

Address Set-Location/Get-Item Issue With ?/* Characters #12294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02d5492
Address Set-Location & Get-Item Issue With ?/* Characters
NoMoreFood Apr 11, 2020
7230f08
Address Set-Location & Get-Item Issue With ?/* Characters - Revisions
NoMoreFood Apr 24, 2020
fed014a
Address Set-Location & Get-Item Issue With ?/* Characters - Revisions
NoMoreFood Jun 9, 2020
737df8f
Address Set-Location & Get-Item Issue With ?/* Characters - Revisions
NoMoreFood Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Management.Automation/namespaces/FileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ private static string GetCorrectCasedPath(string path)

break;
}
else if (item.Contains('~'))
else if (item.Contains('~') || item.IndexOfAny(Utils.Separators.StarOrQuestion) >= 0)
Comment thread
NoMoreFood marked this conversation as resolved.
{
// This handles short path names
// This handles short path names and wildcard characters that could resolve erroneously
exactPath += StringLiterals.DefaultPathSeparator + item;
Comment thread
NoMoreFood marked this conversation as resolved.
}
else
Expand Down
75 changes: 75 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Set-Location.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,4 +230,79 @@ Describe "Set-Location" -Tags "CI" {
$PWD.Path | Should -Be $location.Path
}
}

It 'Should not match directory containing wildcard character *' -Skip:([System.IO.Path]::GetInvalidFileNameChars() -contains '*') {
Set-Location $TestDrive
$currentPath = (Get-Location).Path
$literalPathActual = Join-Path $TestDrive '*****'
$literalPathAttempt = Join-Path $TestDrive 'aaaaa'
New-Item -ItemType Directory -Path $literalPathActual
{ Set-Location -LiteralPath $literalPathAttempt -ErrorAction Stop } | Should -Throw -ErrorId "PathNotFound,Microsoft.PowerShell.Commands.SetLocationCommand"
(Get-Location).Path | Should -BeExactly $currentPath
}

It 'Should not match directory containing wildcard character ?' -Skip:([System.IO.Path]::GetInvalidFileNameChars() -contains '?') {
Set-Location $TestDrive
$currentPath = (Get-Location).Path
$literalPathActual = Join-Path $TestDrive '?????'
$literalPathAttempt = Join-Path $TestDrive 'aaaaa'
New-Item -ItemType Directory -Path $literalPathActual
{ Set-Location -LiteralPath $literalPathAttempt -ErrorAction Stop } | Should -Throw -ErrorId "PathNotFound,Microsoft.PowerShell.Commands.SetLocationCommand"
(Get-Location).Path | Should -BeExactly $currentPath
}
}

Describe "Set-Location: Name with special/wildcards characters" -Tags "CI" {

BeforeAll {

$startLocation = (Get-Location).Path

# printable ascii characters excluding alphanumerics
$specialChars = ' !"#$%&''()*+,-./:;<=>?@[\]^_`{|}~ '.ToCharArray()
$testCases = @()
ForEach ($specialChar in $specialChars) {
If ($specialChar -ne '.') { $testCases += @{Name=([string] $specialChar)} }
$testCases += @{Name=('foo' + $specialChar)}
$testCases += @{Name=($specialChar + 'foo')}
Comment thread
NoMoreFood marked this conversation as resolved.
}
}

It "Should be able to create and set location to <Name>" -TestCases $testCases {
param ( $Name )

# skip unsupported characters for the current platform
if ($Name.IndexOfAny([System.IO.Path]::GetInvalidFileNameChars()) -ge 0 -or `
($IsWindows -and ($Name.EndsWith('.') -or $Name.EndsWith(' ')))) {
Set-ItResult -Skipped -Because "'${Name}' is not supported as directory name on this operating system."
return
}

# note processing of '\' should be allowed on posix systems but
# is quite broken in many powershell cmdlets
if ($Name.Contains('\'))
{
Set-ItResult -Pending -Because "path elements with backslashes are not fully supported in PowerShell on MacOs/Linux."
return
}

$dirFullName = (Join-Path $TestDrive $Name)

$newDir = [System.IO.Directory]::CreateDirectory($dirFullName)
Comment thread
NoMoreFood marked this conversation as resolved.
$newDir.Name | Should -BeExactly $Name

$newDirGetCheck = Get-Item -LiteralPath $dirFullName -Force
$newDirGetCheck.Name | Should -BeExactly $Name

try {
Set-Location -LiteralPath $dirFullName
[System.IO.Path]::GetFileName((Get-Location).Path) | Should -BeExactly $Name
Comment thread
NoMoreFood marked this conversation as resolved.
}
catch {
throw ("Set-Location $Name Failed; Exception: " + $_.Exception.Message)
}
finally {
Set-Location -LiteralPath $startLocation
}
}
}