Skip to content

Fix foreach parallel when current drive is not available #12197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Mar 31, 2020
Merged

Fix foreach parallel when current drive is not available #12197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/System.Management.Automation/engine/hostifaces/PSTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,10 @@ public void Start(Runspace runspace)
Runspace.DefaultRunspace = runspace;
runspace.ExecutionContext.SessionState.Internal.SetLocation(_currentLocationPath);
}
catch (DriveNotFoundException)
{
// Allow task to run if current drive is not available.
Comment thread
SteveL-MSFT marked this conversation as resolved.
}
finally
{
Runspace.DefaultRunspace = oldDefaultRunspace;
Comment thread
iSazonov marked this conversation as resolved.
Expand Down
14 changes: 14 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Foreach-Object-Parallel.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,20 @@ Describe 'ForEach-Object -Parallel Basic Tests' -Tags 'CI' {
$parallelScriptLocation = 1..1 | ForEach-Object -Parallel { $PWD }
$parallelScriptLocation.Path | Should -BeExactly $PWD.Path
}

It 'Verifies no terminating error if current working drive is not found' {
$oldLocation = Get-Location
try
{
New-PSDrive -Name ZZ -PSProvider FileSystem -Root $TestDrive
Set-Location -Path 'ZZ:'
{ 1..1 | ForEach-Object -Parallel { $_ } } | Should -Not -Throw
}
finally
{
Set-Location -Path $oldLocation
}
}
}

Describe 'ForEach-Object -Parallel common parameters' -Tags 'CI' {
Expand Down