Skip to content

Update LICENSE to remove version of PowerShell - #12019

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:update-license
Mar 13, 2020
Merged

Update LICENSE to remove version of PowerShell#12019
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:update-license

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Mar 5, 2020

Copy link
Copy Markdown
Member

PR Summary

Unfortunately, we shipped 7.0 with a License that explicitly calls out 6.0. I'm following up with legal if we can just remove the version altogether.

PR Checklist

Comment thread LICENSE.txt
Comment thread LICENSE.txt
@iSazonov

Copy link
Copy Markdown
Collaborator

Unfortunately, we shipped 7.0 with a License that explicitly calls out 6.0.

Perhaps MSFT could make the release branch public before release so that community could review.

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) we should have caught this when we updated across the source code from 6 to 7. Compliance for building/signing the release means we can't make that public, but it's essentially the same as on GitHub just minor fixes when needed which get pushed back to GitHub anyways. Got confirmation we can leave off the version number, so will update.

Comment thread LICENSE.txt
@iSazonov

Ilya (iSazonov) commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

https://shell.azure.com/ fail in Static CI in last days. (But I can open locally)

@daxian-dbw

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) please retry static

@PoshChan

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), successfully started retry of PowerShell-CI-static-analysis

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit e9152a5 into PowerShell:master Mar 13, 2020
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title Update LICENSE to reflect version of PowerShell Update LICENSE to remove version of PowerShell Mar 16, 2020
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the update-license branch March 16, 2020 17:08
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Mar 24, 2020
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

Copy link
Copy Markdown

🎉v7.0.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants