Skip to content

Fix ConciseView to split PositionMessage using [Environment]::NewLine - #12010

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:conciseview-newline
Mar 4, 2020
Merged

Fix ConciseView to split PositionMessage using [Environment]::NewLine#12010
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:conciseview-newline

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Mar 4, 2020

Copy link
Copy Markdown
Member

PR Summary

The change in #11746 conflicted with #11952 resulted in incorrect splitting of the PositionMessage in the ErrorRecord showing the old NormalView line information. Since we are retaining #11746, need to fix the formatting to use [Environment]::NewLine

PR Context

PR Checklist

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 4, 2020
@daxian-dbw

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) please retry static

@PoshChan

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), successfully started retry of PowerShell-CI-static-analysis

@daxian-dbw

Copy link
Copy Markdown
Member

https://shell.azure.com/ should be back already, not sure why it's failing.

For the preview.md issue reported in the static CI, it's caused by moving preview.md to 7.0.0.md in this commit. Aditya Patwardhan (@adityapatwardhan) can you please fix it?

@daxian-dbw

Copy link
Copy Markdown
Member

I will merge this PR as it has nothing to do with the failures in the static analysis CI.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 348ca85 into PowerShell:master Mar 4, 2020
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants