Make module formatting not generate error with strict mode - #11943
Merged
Travis Plunk (TravisEz13) merged 2 commits intoMay 27, 2020
Merged
Conversation
Steve Lee (SteveL-MSFT)
requested changes
Feb 27, 2020
Dan Thompson (jazzdelightsme)
requested a review
from Steve Lee (SteveL-MSFT)
February 28, 2020 01:26
14 tasks
Contributor
Author
|
Steve Lee (@SteveL-MSFT) Quickest way to get me using a pre-release build would be to ship this change in one. ;) |
Rain Sallow (/u/ta11ow) (vexx32)
approved these changes
Apr 26, 2020
Member
|
Steve Lee (@SteveL-MSFT) Can you update your review? |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Member
|
pinged Steve Lee (@SteveL-MSFT) offline to update his review |
Steve Lee (SteveL-MSFT)
approved these changes
May 27, 2020
Steve Lee (SteveL-MSFT)
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay!
Dan Thompson (jazzdelightsme)
deleted the
user/danthom/strictModuleInfoFix
branch
May 27, 2020 22:55
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11909
PR Summary
Minor tweak to module formatting script to avoid errors when strict mode is on.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.