Auto-sync current directory in WinCompat remote session - #11809
Merged
Aditya Patwardhan (adityapatwardhan) merged 3 commits intoFeb 11, 2020
Merged
Auto-sync current directory in WinCompat remote session#11809Aditya Patwardhan (adityapatwardhan) merged 3 commits into
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
Conversation
Andrew (anmenaga)
requested review from
Steve Lee (SteveL-MSFT) and
Dongbo Wang (daxian-dbw)
February 7, 2020 23:59
Paul Higinbotham (PaulHigin)
suggested changes
Feb 10, 2020
Aditya Patwardhan (adityapatwardhan)
requested changes
Feb 10, 2020
Paul Higinbotham (PaulHigin)
suggested changes
Feb 10, 2020
| # after WinCompat cleanup local $PWD changes should not cause errors | ||
| Remove-module $ModuleName -Force | ||
| Pop-Location | ||
| try |
Contributor
There was a problem hiding this comment.
Actually, I think all code after the first 'Push-Location' should be in the try. If any exception is thrown during the test the original location will be reverted through the finally 'Set-Location'.
Paul Higinbotham (PaulHigin)
approved these changes
Feb 10, 2020
Paul Higinbotham (PaulHigin)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Aditya Patwardhan (adityapatwardhan)
approved these changes
Feb 11, 2020
Aditya Patwardhan (adityapatwardhan)
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Feb 18, 2020
# Conflicts: # src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
|
🎉 Handy links: |
22 tasks
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
WinCompat uses background Windows PS remote session which has its own current directory. It has to be synchronized with local PS Core current directory for cases when proxy cmdlets rely on current directory.
This PR enables auto-sync of current directory in WinCompat remote session.
This came up in #11411 .
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.