Add links to diffs on Github in changelog by xtqqczze · Pull Request #11652 · PowerShell/PowerShell

xtqqczze · 2020-01-21T23:04:15Z

PR Summary

Provide links to the Github compare view for each release.

PR Context

This change provides for an easy method to access Github's compare features.

Commit 8a1d894 from #11644 is included in this branch to ensure an straightforward merge.

PR Checklist

xtqqczze · 2020-01-21T23:05:58Z

We should investigate why Github issues are not being hyperlinked in the changelog.

xtqqczze · 2020-01-21T23:57:50Z

Markdown-link test failure is unrelated.

xtqqczze · 2020-01-22T01:25:29Z

PowerShell-CI-static-analysis failure is unrelated, #11653 will fix.

Ilya (iSazonov) · 2020-01-22T04:47:15Z

Looks great!

Maybe add diffs based on previous major and minor version like 7.0 - 6.0 and 6.2.0 - 6.0.0 ?

Dongbo Wang (daxian-dbw) · 2020-01-22T16:48:33Z

PoshChan-Bot (@PoshChan) Please retry static

PoshChan-Bot (PoshChan) · 2020-01-22T16:49:18Z

Dongbo Wang (@daxian-dbw), successfully started retry of PowerShell-CI-static-analysis

Dongbo Wang (daxian-dbw)

Looks good to me, but I would like to get sign-off from other maintainers too.

Ilya (iSazonov)

LGTM.

As I mentioned above perhaps we could add diffs based on 6.0.0 (later on 7.0.0) for major and minor versions so that users can get a list of the commits from 6.0 to 6.1, from 6.0 to 6.2, from 6.0 to 7.0 and so on.
We can add this in follow PR.

Ilya (iSazonov) · 2020-01-22T16:57:31Z

xtqqczze Please rebase to pass CI static.

Dongbo Wang (daxian-dbw) · 2020-01-22T17:29:57Z

The failure in static build is new and is related to the changes in this PR.

Ilya (iSazonov) · 2020-01-22T17:44:06Z

Perhaps rebase helps.

Change to international date format to match date format in `CHANGELOG/6.1.md` etc.

xtqqczze · 2020-01-26T03:29:20Z

Dongbo Wang (@daxian-dbw) rebase passed checks

Ilya (iSazonov) · 2020-01-26T10:58:14Z

Travis Plunk (@TravisEz13) Aditya Patwardhan (@adityapatwardhan) Have you any objections or we can merge?

Travis Plunk (TravisEz13) · 2020-01-30T18:57:48Z

xtqqczze It would be good if you updated the script to generate the change log with these changes:
https://github.com/PowerShell/PowerShell/blob/master/tools/releaseTools.psm1
The file already has new entries that doesn't match your changes.

GitHub
PowerShell/PowerShell
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

xtqqczze · 2020-01-30T21:18:18Z

Travis Plunk (@TravisEz13) Thanks for your suggestion. I will create a follow-up PR to exclude regressions.

xtqqczze · 2020-01-30T23:56:22Z

xtqqczze It would be good if you updated the script to generate the change log with these changes:
https://github.com/PowerShell/PowerShell/blob/master/tools/releaseTools.psm1

Travis Plunk (@TravisEz13) Please see #11736

GitHub
PowerShell/PowerShell
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

xtqqczze · 2020-02-01T12:35:01Z

As I mentioned above perhaps we could add diffs based on 6.0.0 (later on 7.0.0) for major and minor versions so that users can get a list of the commits from 6.0 to 6.1, from 6.0 to 6.2, from 6.0 to 7.0 and so on.
We can add this in follow PR.

Ilya (@iSazonov) I'm not sure we would present these additional diffs, so I'll leave this up-for grabs.

# PR Summary * Fix regression from #11652 * Fix [MD022](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md032---lists-should-be-surrounded-by-blank-lines) / [MD032](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md032---lists-should-be-surrounded-by-blank-lines) rule violations * Modify `Get-ChangeLog` to generate the changelog according to the format from #11652. ## PR Context Follow-up to #11652 ## PR Checklist - [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - Use the present tense and imperative mood when describing your changes - [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready. - **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)** - [x] None - **OR** - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md) - [ ] Experimental feature name(s):  - **User-facing changes** - [x] Not Applicable - **OR** - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] Issue filed:  - **Testing - New and feature** - [x] N/A or can only be tested interactively - **OR** - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting) - **Tooling** - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. - **OR** - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host). - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions). - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Deleted user (ghost) · 2020-02-21T23:53:39Z

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

# PR Summary Add link to Github compare in `CHANGELOG\preview.md` ## PR Context follow-up #11652 ## PR Checklist - [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - Use the present tense and imperative mood when describing your changes - [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready. - **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)** - [x] None - **OR** - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md) - [ ] Experimental feature name(s):  - **User-facing changes** - [x] Not Applicable - **OR** - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] Issue filed:  - **Testing - New and feature** - [x] N/A or can only be tested interactively - **OR** - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting) - **Tooling** - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. - **OR** - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host). - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions). - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

* Use consistent date format in markdown files Change to international date format to match date format in `CHANGELOG/6.1.md` etc. * Add links to compare views on Github

# PR Summary * Fix regression from PowerShell#11652 * Fix [MD022](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md032---lists-should-be-surrounded-by-blank-lines) / [MD032](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md032---lists-should-be-surrounded-by-blank-lines) rule violations * Modify `Get-ChangeLog` to generate the changelog according to the format from PowerShell#11652. ## PR Context Follow-up to PowerShell#11652 ## PR Checklist - [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - Use the present tense and imperative mood when describing your changes - [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready. - **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)** - [x] None - **OR** - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md) - [ ] Experimental feature name(s):  - **User-facing changes** - [x] Not Applicable - **OR** - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] Issue filed:  - **Testing - New and feature** - [x] N/A or can only be tested interactively - **OR** - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting) - **Tooling** - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. - **OR** - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host). - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions). - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

# PR Summary Add link to Github compare in `CHANGELOG\preview.md` ## PR Context follow-up PowerShell#11652 ## PR Checklist - [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - Use the present tense and imperative mood when describing your changes - [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready. - **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)** - [x] None - **OR** - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md) - [ ] Experimental feature name(s):  - **User-facing changes** - [x] Not Applicable - **OR** - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] Issue filed:  - **Testing - New and feature** - [x] N/A or can only be tested interactively - **OR** - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting) - **Tooling** - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. - **OR** - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host). - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions). - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

ghost assigned Aditya Patwardhan (adityapatwardhan) Jan 21, 2020

xtqqczze force-pushed the feature-changelog-github-compare branch from 820abb5 to 1210042 Compare January 22, 2020 01:23

Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) January 22, 2020 16:48

Dongbo Wang (daxian-dbw) approved these changes Jan 22, 2020

View reviewed changes

Dongbo Wang (daxian-dbw) requested a review from Ilya (iSazonov) January 22, 2020 16:49

Ilya (iSazonov) approved these changes Jan 22, 2020

View reviewed changes

xtqqczze added 2 commits January 23, 2020 04:06

Use consistent date format in markdown files

0eab64d

Change to international date format to match date format in `CHANGELOG/6.1.md` etc.

Add links to compare view on Github

5f2a89b

xtqqczze force-pushed the feature-changelog-github-compare branch from 1210042 to 5f2a89b Compare January 23, 2020 04:07

Travis Plunk (TravisEz13) approved these changes Jan 28, 2020

View reviewed changes

Travis Plunk (TravisEz13) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 28, 2020

Travis Plunk (TravisEz13) added this to the 7.1.0-preview.1 milestone Jan 28, 2020

Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Aditya Patwardhan (adityapatwardhan) Jan 29, 2020

Ilya (iSazonov) merged commit 148124e into PowerShell:master Jan 29, 2020

xtqqczze mentioned this pull request Jan 29, 2020

Use consistent date format in markdown files #11644

Closed

14 tasks

xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Jan 30, 2020

Fix regression from PowerShell#11652

d68456f

xtqqczze mentioned this pull request Jan 30, 2020

Update changelog generation script #11736

Merged

14 tasks

xtqqczze mentioned this pull request May 18, 2020

Add link to Github compare in changelog #12713

Merged

14 tasks

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

Uh oh!

Conversation

xtqqczze commented Jan 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

xtqqczze commented Jan 21, 2020

Uh oh!

xtqqczze commented Jan 21, 2020

Uh oh!

xtqqczze commented Jan 22, 2020

Uh oh!

Ilya (iSazonov) commented Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 22, 2020

Uh oh!

PoshChan-Bot (PoshChan) commented Jan 22, 2020

Uh oh!

Dongbo Wang (daxian-dbw) left a comment

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) left a comment

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Jan 22, 2020

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 22, 2020

Uh oh!

Ilya (iSazonov) commented Jan 22, 2020

Uh oh!

xtqqczze commented Jan 26, 2020

Uh oh!

Ilya (iSazonov) commented Jan 26, 2020

Uh oh!

Travis Plunk (TravisEz13) commented Jan 30, 2020 • edited by unfurl-links Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xtqqczze commented Jan 30, 2020

Uh oh!

xtqqczze commented Jan 30, 2020 • edited by unfurl-links Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xtqqczze commented Feb 1, 2020

Uh oh!

Deleted user (ghost) commented Feb 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xtqqczze commented Jan 21, 2020 •

edited

Loading

Ilya (iSazonov) commented Jan 22, 2020 •

edited

Loading

Travis Plunk (TravisEz13) commented Jan 30, 2020 •

edited by unfurl-links Bot

Loading

xtqqczze commented Jan 30, 2020 •

edited by unfurl-links Bot

Loading