PowerShell · James Truher (JamesWTruher) · Feb 19, 2020 · Feb 19, 2020 · Feb 19, 2020 · Feb 19, 2020
@@ -8,24 +8,52 @@ update_configs:
     update_schedule: "live"
     default_labels:
       - "CL-BuildPackaging"
+    ignored_updates:
+      - match:
+          dependency_name: "System.*"
+      - match:
+          dependency_name: "Microsoft.Win32.Registry.AccessControl"
+      - match:
+          dependency_name: "Microsoft.Windows.Compatibility"
 
   - package_manager: "dotnet:nuget"
     directory: "/tools/packaging/projects/reference/Microsoft.PowerShell.Commands.Utility"
     update_schedule: "live"
     default_labels:
       - "CL-BuildPackaging"
+    ignored_updates:
+      - match:
+          dependency_name: "System.*"
+      - match:
+          dependency_name: "Microsoft.Win32.Registry.AccessControl"
+      - match:
+          dependency_name: "Microsoft.Windows.Compatibility"
 
   - package_manager: "dotnet:nuget"
     directory: "/tools/packaging/projects/reference/System.Management.Automation"
     update_schedule: "live"
     default_labels:
       - "CL-BuildPackaging"
+    ignored_updates:
+      - match:
+          dependency_name: "System.*"
+      - match:
+          dependency_name: "Microsoft.Win32.Registry.AccessControl"
+      - match:
+          dependency_name: "Microsoft.Windows.Compatibility"
 
   - package_manager: "dotnet:nuget"
     directory: "/test/tools/Modules"
     update_schedule: "live"
     default_labels:
       - "CL-BuildPackaging"
+    ignored_updates:
+      - match:
+          dependency_name: "System.*"
+      - match:
+          dependency_name: "Microsoft.Win32.Registry.AccessControl"
+      - match:
+          dependency_name: "Microsoft.Windows.Compatibility"
 
   - package_manager: "dotnet:nuget"
     directory: "/src/Modules"

@@ -1,9 +1,9 @@
 #-------------------------------------------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
+# Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
 #-------------------------------------------------------------------------------------------------------------
 
-FROM mcr.microsoft.com/dotnet/core/sdk:3.1.101
+FROM mcr.microsoft.com/dotnet/core/sdk:5.0.100-preview.2
 
 # Avoid warnings by switching to noninteractive
 ENV DEBIAN_FRONTEND=noninteractive
@@ -13,7 +13,7 @@ RUN apt-get update \
     && apt-get -y install --no-install-recommends apt-utils 2>&1 \
     #
     # Verify git, process tools, lsb-release (common in install instructions for CLIs) installed
-    && apt-get -y install git procps lsb-release \
+    && apt-get -y install --no-install-recommends git procps lsb-release \
     #
     # Clean up
     && apt-get autoremove -y \

@@ -1,14 +1,14 @@
 // See https://aka.ms/vscode-remote/devcontainer.json for format details.
 {
-	"name": ".NET Core 3.1, including pwsh (Debian 10)",
+	"name": ".NET Core 5.0, including pwsh (Debian 10)",
 	"dockerFile": "Dockerfile",
 
 	// Uncomment the next line to run commands after the container is created.
 	"postCreateCommand": "cd src/powershell-unix && dotnet restore",
 
 	"extensions": [
 		"ms-azure-devops.azure-pipelines",
-		"ms-vscode.csharp",
+		"ms-dotnettools.csharp",
 		"ms-vscode.powershell",
 		"DavidAnson.vscode-markdownlint",
 		"vitaliymaz.vscode-svg-previewer"

@@ -8,7 +8,7 @@
 
 	"extensions": [
 		"ms-azure-devops.azure-pipelines",
-		"ms-vscode.csharp",
+		"ms-dotnettools.csharp",
 		"ms-vscode.powershell",
 		"DavidAnson.vscode-markdownlint",
 		"vitaliymaz.vscode-svg-previewer"

@@ -48,6 +48,9 @@ indent_size = 2
 # Sort using and Import directives with System.* appearing first
 dotnet_sort_system_directives_first = true
 
+# Modifier preferences
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
+
 # Avoid "this." and "Me." if not necessary
 dotnet_style_qualification_for_field = false:suggestion
 dotnet_style_qualification_for_property = false:suggestion

@@ -33,7 +33,7 @@ src/Microsoft.PowerShell.Commands.Management/      @daxian-dbw @adityapatwardhan
 src/Microsoft.PowerShell.Commands.Utility/         @JamesWTruher @PaulHigin
 
 # Area: Console
-src/Microsoft.PowerShell.ConsoleHost/              @daxian-dbw @anmenaga
+src/Microsoft.PowerShell.ConsoleHost/              @daxian-dbw @anmenaga @TylerLeonhardt
 
 # Area: Demos
 demos/                                             @joeyaiello @SteveL-MSFT @HemantMahawar

@@ -19,7 +19,7 @@ Please read the rest of this document to ensure a smooth contribution process.
 
 ## Quick Start Checklist
 
-* Review the [Contribution License Agreement][CLA] requirement.
+* Review the [Contributor License Agreement][CLA] requirement.
 * Get familiar with the [PowerShell repository](../docs/git).
 
 ## Contributing to Issues
@@ -115,7 +115,7 @@ Please see [Building PowerShell](../README.md#building-the-repository).
 
 #### Testing PowerShell
 
-Please see PowerShell [Testing Guidelines - Running Tests Outside of CI][running-tests-outside-of-ci] on how to test you build locally.
+Please see PowerShell [Testing Guidelines - Running Tests Outside of CI][running-tests-outside-of-ci] on how to test your build locally.
 
 ### Finding or creating an issue
 
@@ -167,11 +167,11 @@ Additional references:
   An issue title is to briefly describe what is wrong, while a PR title is to briefly describe what is changed.
   A better example is: "Add Ensure parameter to New-Item cmdlet", with "Fix #5" in the PR's body.
 * When you create a pull request,
-  including a summary about your changes in the PR description.
+  include a summary about your changes in the PR description.
   The description is used to create change logs,
   so try to have the first sentence explain the benefit to end users.
   If the changes are related to an existing GitHub issue,
-  please reference the issue in PR description (e.g. ```Fix #11```).
+  please reference the issue in the PR description (e.g. ```Fix #11```).
   See [this][closing-via-message] for more details.
 
 * Please use the present tense and imperative mood when describing your changes:
@@ -196,15 +196,15 @@ Additional references:
     * For `.h`, `.cpp`, and `.cs` files use the copyright header with empty line after it:
 
     ```c#
-        // Copyright (c) Microsoft Corporation. All rights reserved.
+        // Copyright (c) Microsoft Corporation.
         // Licensed under the MIT License.
         <Add empty line here>
     ```
 
     * For `.ps1` and `.psm1` files use the copyright header with empty line after it:
 
     ```powershell
-        # Copyright (c) Microsoft Corporation. All rights reserved.
+        # Copyright (c) Microsoft Corporation.
         # Licensed under the MIT License.
         <Add empty line here>
     ```
@@ -214,7 +214,7 @@ Additional references:
   ```powershell
   Author = "PowerShell"
   Company = "Microsoft Corporation"
-  Copyright = "Copyright (c) Microsoft Corporation. All rights reserved."
+  Copyright = "Copyright (c) Microsoft Corporation."
   ```
 
   is at the top.
@@ -277,10 +277,10 @@ Additional references:
    - `Request changes` if you believe the PR merge should be blocked if your feedback is not addressed,
    - `Approve` if you believe your feedback has been addressed or the code is fine as-is, it is customary (although not required) to leave a simple "Looks good to me" (or "LGTM") as the comment for approval.
    - `Comment` if you are making suggestions that the *author* does not have to accept.
-   Early in the review, it is acceptable to provide feedback on coding formatting based on the published [Coding Guidelines](../docs/dev-process/coding-guidelines.md), however,
-   after the PR has been approved, it is generally _not_ recommended to focus on formatting issues unless they go against the [Coding Guidelines](../docs/dev-process/coding-guidelines.md).
+   Early in the review, it is acceptable to provide feedback on coding formatting based on the published [Coding Guidelines][coding-guidelines], however,
+   after the PR has been approved, it is generally _not_ recommended to focus on formatting issues unless they go against the [Coding Guidelines][coding-guidelines].
    Non-critical late feedback (after PR has been approved) can be submitted as a new issue or new pull request from the *reviewer*.
-1. *Assignee* who are always *Maintainers* ensure that proper review has occurred and if they believe one approval is not sufficient, the *maintainer* is responsible to add more reviewers.
+1. *Assignees* who are always *Maintainers* ensure that proper review has occurred and if they believe one approval is not sufficient, the *maintainer* is responsible to add more reviewers.
    An *assignee* may also be a reviewer, but the roles are distinct.
    Once the PR has been approved and the CI system is passing, the *assignee* will merge the PR after giving one business day for any critical feedback.
    For more information on the PowerShell Maintainers' process, see the [documentation](../docs/maintainers).
@@ -302,22 +302,22 @@ In these cases:
 ## Making Breaking Changes
 
 When you make code changes,
-please pay attention to these that can affect the [Public Contract](../docs/dev-process/breaking-change-contract.md).
+please pay attention to these that can affect the [Public Contract][breaking-changes-contract].
 For example, changing PowerShell parameters, APIs, or protocols break the public contract.
 Before making changes to the code,
-first review the [breaking changes contract](../docs/dev-process/breaking-change-contract.md)
+first review the [breaking changes contract][breaking-changes-contract]
 and follow the guidelines to keep PowerShell backward compatible.
 
 ## Making Design Changes
 
 To add new features such as cmdlets or making design changes,
-please follow the [PowerShell Request for Comments (RFC)](https://github.com/PowerShell/PowerShell-RFC) process.
+please follow the [PowerShell Request for Comments (RFC)][rfc-process] process.
 
 ## Common Engineering Practices
 
-Other than the guidelines for ([coding](../docs/dev-process/coding-guidelines.md),
-the [RFC process](https://github.com/PowerShell/PowerShell-RFC) for design,
-[documentation](#contributing-to-documentation) and [testing](../docs/testing-guidelines/testing-guidelines.md)) discussed above,
+Other than the guidelines for [coding][coding-guidelines],
+the [RFC process][rfc-process] for design,
+[documentation](#contributing-to-documentation) and [testing](../docs/testing-guidelines/testing-guidelines.md) discussed above,
 we encourage contributors to follow these common engineering practices:
 
 * Format commit messages following these guidelines:
@@ -359,7 +359,7 @@ is also appropriate, as is using Markdown syntax.
   If you find code that you think is a good fit to add to PowerShell,
   file an issue and start a discussion before proceeding.
 * Create and/or update tests when making code changes.
-* Run tests and ensure they are passing before pull request.
+* Run tests and ensure they are passing before opening a pull request.
 * All pull requests **must** pass CI systems before they can be approved.
 * Avoid making big pull requests.
   Before you invest a large amount of time,
@@ -368,7 +368,7 @@ is also appropriate, as is using Markdown syntax.
 ## Contributor License Agreement (CLA)
 
 To speed up the acceptance of any contribution to any PowerShell repositories,
-you should to [sign a Microsoft Contribution Licensing Agreement (CLA)](https://cla.microsoft.com/) ahead of time.
+you should sign the Microsoft [Contributor License Agreement (CLA)](https://cla.microsoft.com/) ahead of time.
 If you've already contributed to PowerShell or Microsoft repositories in the past, congratulations!
 You've already completed this step.
 This a one-time requirement for the PowerShell project.
@@ -395,8 +395,10 @@ Once you sign a CLA, all your existing and future pull requests will have the st
 [up-for-grabs]: https://github.com/powershell/powershell/issues?q=is%3Aopen+is%3Aissue+label%3AUp-for-Grabs
 [semantic linefeeds]: https://rhodesmill.org/brandon/2012/one-sentence-per-line/
 [PowerShell-Docs]: https://github.com/powershell/powershell-docs/
-[use-vscode-editor]: ../docs/learning-powershell/using-vscode.md#editing-with-visual-studio-code
+[use-vscode-editor]: https://docs.microsoft.com/dotnet/core/tutorials/with-visual-studio-code
 [repository-maintainer]: ../docs/community/governance.md#repository-maintainers
 [area-expert]: ../docs/community/governance.md#area-experts
-[ci-system]: ../docs/testing-guidelines/testing-guidelines.md#ci-system
 [first-time-issue]: https://github.com/powershell/powershell/issues?q=is%3Aopen+is%3Aissue+label%3AFirst-Time-Issue
+[coding-guidelines]: ../docs/dev-process/coding-guidelines.md
+[breaking-changes-contract]: ../docs/dev-process/breaking-change-contract.md
+[rfc-process]: https://github.com/PowerShell/PowerShell-RFC
@@ -16,29 +16,29 @@ This repository is **ONLY** for PowerShell Core 6 and PowerShell 7+ issues.
 - Make sure you are able to repro it on the [latest released version](https://github.com/PowerShell/PowerShell/releases)
 - Search the existing issues.
 - Refer to the [FAQ](https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md).
-- Refer to the [known issues](https://docs.microsoft.com/powershell/scripting/whats-new/known-issues-ps6?view=powershell-6).
+- Refer to the [known issues](https://docs.microsoft.com/powershell/scripting/whats-new/known-issues-ps6).
 
 -->
 
-# Steps to reproduce
+## Steps to reproduce
 
 ```powershell
 
 ```
 
-# Expected behavior
+## Expected behavior
 
 ```none
 
 ```
 
-# Actual behavior
+## Actual behavior
 
 ```none
 
 ```
 
-# Environment data
+## Environment data
 
 <!-- provide the output of $PSVersionTable -->
 

@@ -1,30 +1,35 @@
 ---
 name: Distribution Support Request
-about: Requests suppoort for a new distribution
+about: Requests support for a new distribution
 title: "Distribution Support Request"
 labels: Distribution-Request
 assignees: ''
 
 ---
 
-# Details of the Distribution
+## Details of the Distribution
 
-- Name of the Distribution: 
+- Name of the Distribution:
 - Version of the Distribution:
-- Processor Architecture (One per request): 
+- Package Types
+    - [ ] Deb
+    - [ ] RPM
+    - [ ] Tar.gz
+    - Snap - Please file issue in https://github.com/powershell/powershell-snap.  This issues type is unrelated to snap packages with a distribution neutral.
+- Processor Architecture (One per request):
 - [ ] **Required** - An issues has been filed to create a Docker image in https://github.com/powershell/powershell-docker
 - The following is a requirement for supporting a distribution **without exception.**
-  - [ ] The version and architecture of the Distribution is [supported by .NET Core](https://github.com/dotnet/core/blob/master/release-notes/3.0/3.0-supported-os.md#linux).
+    - [ ] The version and architecture of the Distribution is [supported by .NET Core](https://github.com/dotnet/core/blob/master/release-notes/3.0/3.0-supported-os.md#linux).
 - The following are requirements for supporting a distribution.
-  Please write a justification for any exception where these criteria are not met and 
-  the PowerShell comittee will review the request.
-  - [ ] The version of the Distribution is supported for at least one year.
-  - [ ] The version of the Distribution is not an [interim release](https://ubuntu.com/about/release-cycle) or equivalent.
+  Please write a justification for any exception where these criteria are not met and
+  the PowerShell committee will review the request.
+    - [ ] The version of the Distribution is supported for at least one year.
+    - [ ] The version of the Distribution is not an [interim release](https://ubuntu.com/about/release-cycle) or equivalent.
 
 ## Progress - For PowerShell Team **ONLY**
 
 - [ ] Docker image created
 - [ ] Docker image published
 - [ ] Distribution tested
-- [ ] Lifecycle updated
+- [ ] [Lifecycle](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/docs-conceptual/PowerShell-Support-Lifecycle.md) updated
 - [ ] Documentation Updated
@@ -7,15 +7,15 @@ assignees: ''
 
 ---
 
-# Summary of the new feature/enhancement
+## Summary of the new feature/enhancement
 
 <!-- 
 A clear and concise description of what the problem is that the new feature would solve.
 Try formulating it in user story style (if applicable):
 'As a user I want X so that Y.' with X being the being the action and Y being the value of the action.
 -->
 
-# Proposed technical implementation details (optional)
+## Proposed technical implementation details (optional)
 
 <!-- 
 A clear and concise description of what you want to happen.

@@ -12,7 +12,7 @@ This template is for maintainers to create an issues to track the release proces
 Please **only** use this template if you are a maintainer.
 -->
 
-# Release Process for v6.x.x
+## Checklist
 
 - [ ] Verify that `PowerShell-Native` has been updated/released as needed.
 - [ ] Check for `PowerShellGet` and `PackageManagement` release plans.

@@ -7,7 +7,7 @@ assignees: 'TravisEz13'
 
 ---
 
-# Security Issue
+## Security Issue
 
 Excerpt from [Issue Management - Security Vulnerabilities](https://github.com/PowerShell/PowerShell/blob/master/.github/SECURITY.md)
 

@@ -5,9 +5,9 @@ If you do not see your problem captured, please file a [new issue][] and follow
 Also make sure to see the [Official Support Policy][].
 If you know how to fix the issue, feel free to send a pull request our way. (The [Contribution Guides][] apply to that pull request, you may want to give it a read!)
 
-[Official Support Policy]: https://docs.microsoft.com/powershell/scripting/powershell-support-lifecycle?view=powershell-6
+[Official Support Policy]: https://docs.microsoft.com/powershell/scripting/powershell-support-lifecycle
 [FAQ]: https://github.com/PowerShell/PowerShell/tree/master/docs/FAQ.md
 [Contribution Guides]: https://github.com/PowerShell/PowerShell/tree/master/.github/CONTRIBUTING.md
-[known issues]: https://docs.microsoft.com/powershell/scripting/whats-new/known-issues-ps6?view=powershell-6
+[known issues]: https://docs.microsoft.com/powershell/scripting/whats-new/known-issues-ps6
 [GitHub issues]: https://github.com/PowerShell/PowerShell/issues
 [new issue]: https://github.com/PowerShell/PowerShell/issues/new/choose
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,7 +7,7 @@ assignees: 'TravisEz13' @@
     ---
-    # Security Issue
+    ## Security Issue
     Excerpt from [Issue Management - Security Vulnerabilities](https://github.com/PowerShell/PowerShell/blob/master/.github/SECURITY.md)
@@ Expand Down @@