Skip to content

Only enable experimental features prior to RC #11162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 4 commits into from
Dec 3, 2019
Merged

Only enable experimental features prior to RC #11162

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b805fab
Only enable experimental features prior to RC
TravisEz13 Nov 22, 2019
e51305d
Address PR comment
TravisEz13 Nov 22, 2019
6cd21df
fix typo
TravisEz13 Nov 22, 2019
268314f
Update build.psm1
TravisEz13 Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,30 @@ function Test-IsPreview
return $Version -like '*-*'
}

<#
.Synopsis
Tests if a version is a Release Candidate
.EXAMPLE
Test-IsReleaseCandidate -version '6.1.0-sometthing' # returns false
Test-IsReleaseCandidate -version '6.1.0-rc.1' # returns true
Test-IsReleaseCandidate -version '6.1.0' # returns false
#>
function Test-IsReleaseCandidate
{
param(
[parameter(Mandatory)]
[string]
$Version
)

if ($Version -like '*-rc.*')
{
return $true
}

return $false
}

function Start-PSBuild {
[CmdletBinding(DefaultParameterSetName="Default")]
param(
Expand Down Expand Up @@ -508,6 +532,7 @@ Fix steps:
# ARM is cross compiled, so we can't run pwsh to enumerate Experimental Features
if (-not $SkipExperimentalFeatureGeneration -and
(Test-IsPreview $psVersion) -and
-not (Test-IsReleaseCandidate $psVersion) -and
-not $Runtime.Contains("arm") -and
-not ($Runtime -like 'fxdependent*')) {

Expand Down