Add an implementation of `Stop-Computer` for Linux and macOS by brendandburns · Pull Request #11151 · PowerShell/PowerShell

Brendan Burns (brendandburns) · 2019-11-22T00:47:48Z

PR Summary

Adds an implementation of the Stop-Computer cmdlet for Linux and OS X

PR Context

Closes #5448

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
User-facing changes
- Documentation needed
  - Issue filed: Doc: Stop-Computer for non-Windows MicrosoftDocs/PowerShell-Docs#5171
Testing - New and feature
- N/A or can only be tested interactively
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

Brendan Burns (brendandburns) · 2019-11-22T06:16:30Z

I'm pretty sure the Windows CI run is a flake.

Travis Plunk (TravisEz13) · 2019-11-22T20:46:03Z

Please don't prevent cross compilation. Pass in the property from the build.psm1. You can then default the property if it is not set from the commandline.

Example:

PowerShell/PowerShell.Common.props

Line 115 in c17d5a7

<IsWindows Condition="'$(IsWindows)' =='true' or ( '$(IsWindows)' == '' and '$(OS)' == 'Windows_NT')">true</IsWindows>

PowerShell/build.psm1

Line 347 in c17d5a7

$Arguments += "/property:IsWindows=true"

Fixed to be a runtime thing.

Travis Plunk (TravisEz13)

see comment

Travis Plunk (TravisEz13) · 2019-11-22T20:49:53Z

Is there a reason start-process won't work?

I think you mean the C# Process class

Yes, here is an example:

PowerShell/src/Microsoft.PowerShell.Commands.Management/commands/management/Clipboard.cs

Line 19 in 9851b07

private static string StartProcess(

Travis Plunk (TravisEz13) · 2019-11-22T20:54:04Z

-P is not an option on the macOS shutdown

Travis Plunk (TravisEz13) · 2019-11-22T20:55:56Z

How do we handle it when the user doesn't have permissions to shutdown?

The command will error out and we (now) write the error code to the stream.

Travis Plunk (TravisEz13) · 2019-11-22T22:15:18Z

Brendan Burns (@brendandburns) I had the CI system rerun the flaky tests and filed: #11168

Paul Higinbotham (PaulHigin)

Overall looks good. I would like to see Restart-Computer also be enabled for non-Windows platforms.

Brendan Burns (brendandburns) · 2019-11-25T21:37:08Z

Comments addressed, please re-check.

Brendan Burns (brendandburns) · 2019-11-26T18:22:54Z

comments addressed, please take another look.

Paul Higinbotham (PaulHigin)

LGTM

Brendan Burns (brendandburns) · 2019-11-27T05:20:12Z

Steve Lee (@SteveL-MSFT) comments addressed, please take another look.

Thanks!

Steve Lee (SteveL-MSFT)

LGTM

Brendan Burns (brendandburns) · 2019-12-03T00:10:55Z

Travis Plunk (@TravisEz13) any chance you can take another look here, I'd love to see this merged since I have a follow up PR to share once it is merged.

Travis Plunk (TravisEz13) · 2019-12-03T01:28:29Z

Brendan Burns (@brendandburns) Sorry, I've been out of the office.

Deleted user (ghost) · 2020-03-26T17:47:15Z

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…ell#11151)

Brendan Burns (brendandburns) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 22, 2019 00:47

Brendan Burns (brendandburns) force-pushed the stop branch 4 times, most recently from 55c7dbb to db7bb30 Compare November 22, 2019 05:39

Travis Plunk (TravisEz13) reviewed Nov 22, 2019

View reviewed changes

Travis Plunk (TravisEz13) requested changes Nov 22, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 22, 2019

Travis Plunk (TravisEz13) reviewed Nov 22, 2019

View reviewed changes

Travis Plunk (TravisEz13) self-assigned this Nov 22, 2019

Steve Lee (SteveL-MSFT) reviewed Nov 22, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated

Paul Higinbotham (PaulHigin) suggested changes Nov 22, 2019

View reviewed changes

Brendan Burns (brendandburns) force-pushed the stop branch from db7bb30 to 46a4bf9 Compare November 25, 2019 21:10

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 25, 2019

Brendan Burns (brendandburns) force-pushed the stop branch 5 times, most recently from 8afdfc1 to 1be3fb8 Compare November 25, 2019 21:35

Brendan Burns (brendandburns) force-pushed the stop branch 2 times, most recently from 90c6695 to 919fc84 Compare November 25, 2019 22:02

Paul Higinbotham (PaulHigin) reviewed Nov 25, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated

Paul Higinbotham (PaulHigin) reviewed Nov 25, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated

Brendan Burns (brendandburns) force-pushed the stop branch from 919fc84 to e265870 Compare November 26, 2019 18:22

Paul Higinbotham (PaulHigin) approved these changes Nov 26, 2019

View reviewed changes

Steve Lee (SteveL-MSFT) requested changes Nov 26, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 26, 2019

Brendan Burns (brendandburns) force-pushed the stop branch from e265870 to 428c61d Compare November 27, 2019 04:59

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 27, 2019

Add Stop-Computer for Linux and MacOSX

f3600eb

Brendan Burns (brendandburns) force-pushed the stop branch from 428c61d to f3600eb Compare November 27, 2019 05:18

Steve Lee (SteveL-MSFT) approved these changes Nov 28, 2019

View reviewed changes

Travis Plunk (TravisEz13) approved these changes Dec 3, 2019

View reviewed changes

Travis Plunk (TravisEz13) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 3, 2019

Travis Plunk (TravisEz13) added this to the 7.1.0-preview.1 milestone Dec 3, 2019

Travis Plunk (TravisEz13) changed the title ~~Add an implementation of Stop-Computer for Linux and OS X.~~ Add an implementation of Stop-Computer for Linux and macOS Dec 3, 2019

Travis Plunk (TravisEz13) merged commit d38541f into PowerShell:master Dec 3, 2019

Brendan Burns (brendandburns) mentioned this pull request Dec 11, 2019

Refactor and implement Restart-Computer for Un*x and macOS #11319

Merged

7 tasks

ghost mentioned this pull request Mar 26, 2020

Missing Stop-Computer cmdlet #5448

Closed

Rain Sallow (/u/ta11ow) (vexx32) mentioned this pull request Apr 24, 2020

Design Issues in Unix versions of Stop/Restart-Computer cmdlets #12482

Closed

Chase Wilson (chasewilson) mentioned this pull request May 20, 2020

Add Restart-Computer for Un*x and macOS MicrosoftDocs/PowerShell-Docs#5979

Closed

12 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Add an implementation of Stop-Computer for Linux and macOS (PowerSh…

c314770

…ell#11151)

Uh oh!

Conversation

Brendan Burns (brendandburns) commented Nov 22, 2019 • edited by SteveL-MSFT Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Brendan Burns (brendandburns) commented Nov 22, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) commented Nov 22, 2019

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brendan Burns (brendandburns) commented Nov 25, 2019

Uh oh!

Uh oh!

Uh oh!

Brendan Burns (brendandburns) commented Nov 26, 2019

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brendan Burns (brendandburns) commented Nov 27, 2019

Uh oh!

Steve Lee (SteveL-MSFT) left a comment

Choose a reason for hiding this comment

Uh oh!

Brendan Burns (brendandburns) commented Dec 3, 2019

Uh oh!

Travis Plunk (TravisEz13) commented Dec 3, 2019

Uh oh!

Deleted user (ghost) commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Brendan Burns (brendandburns) commented Nov 22, 2019 •

edited by SteveL-MSFT

Loading