What family of distro's does this work with?

Arch Linux at the very least (in fact, community-maintained Arch packages are mentioned here, but they are being built manually), probably also its derivatives. And I suppose some Gentoo people could also make use of this.

I can successfully build PowerShell on my Arch PC with this change when using the build module.

Krzysztof Bogacki (@Saancreed) some feature that rely on native component may not work, such as WinRM based remoting.

Travis Plunk (@TravisEz13) for which I think it's fair to warn. But I don't see a specific need to hamper efforts to expand PS's possibilities on "not supported" architectures. The warning message seems appropriate and still allows enterprising users the ability to at least try despite the potential for some missing / broken bits and pieces. 🙂

Travis Plunk (@TravisEz13) That is true, and frankly I'm not sure if I can somehow check that. But if some features are indeed broken, then using binaries built and linked against whatever glibc and openssl some distros currently use can help more than it can hurt.

Rain Sallow (/u/ta11ow) (@vexx32) Yep, if Arch users can make (parts of) PowerShell work that it's worth to make an AUR package, then they will use it even if some things don't work.

Krzysztof Bogacki (@Saancreed) Thanks for your contribution!

I think we need to add new explicit switch parameter (-SkipLinuxDistroCheck with a comment that it is not supported) to enable the scenario without a risk to break supported build scenario.

Ilya (@iSazonov) Supported build scenarios shouldn't be affected by this change at all, so introducing extra switch seems redundant (and makes the change not as simple as I orginally intended). The message itself is still printed to the console as warning, which preserves its visibility but still makes it clear to the user that building in such environments is not officially supported.

That said, if PowerShell team prefers a switch over succeeding with a warning, I can try and rewrite this PR into something like that.

We change Build.psm1 module frequently. I believe the new switch will protect both the proposed scenario and regular build scenarios too. Also for the switch we could add a comment that the scenario is not supported and not recommended.
Travis Plunk (@TravisEz13) Thoughts?

I tend to agree with Ilya (@iSazonov) . The error message can tell you about the switch to bypass the check.

Ilya (@iSazonov) Travis Plunk (@TravisEz13) Sounds fair, but one issue I can see is that the error is thrown when the module is imported, and there we can pass arguments only with -ArgumentList which is not very self-descriptive. Would leaving the warning on import and adding said switch to Start-PSBuild (and perhaps some other functions as well?) that causes the function to throw the error instead be an acceptable solution?

You could update the message to inform user how bypass. So if we import the module without the argument we get throw and the message ("use ipmo .\Build.psm1 -ArgumentList SkipLinuxDistroCheck"). If we import with the argument we don't throw and get only warning that the scenario is not supported.

Travis Plunk (@TravisEz13) Ilya (@iSazonov) Any thoughts on the second iteration of this PR?

restarted static analysis

PoshChan-Bot (@PoshChan) Please remind me in 1 day

Travis Plunk (@TravisEz13), this is the reminder you requested 1 day ago

PoshChan-Bot (@PoshChan) Please remind me in 5 days

Travis Plunk (@TravisEz13), this is the reminder you requested 5 days ago

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

Krzysztof Bogacki (@Saancreed) Please resolve merge conflicts.

Travis Plunk (@TravisEz13) The PR is waiting your review.

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes