Repository navigation
Add any/all lambda containment operators - #11068
Closed
Mathias R. Jessen (IISResetMe) wants to merge 6 commits into
Closed
Mathias R. Jessen (IISResetMe) wants to merge 6 commits into
Mathias R. Jessen (IISResetMe) wants to merge 6 commits into
Conversation
Mathias R. Jessen (IISResetMe)
added a commit
to IISResetMe/EditorSyntax
that referenced
this pull request
Nov 14, 2019
To reflect changes to binary comparison operators in PowerShell/PowerShell#11068
Mathias R. Jessen (IISResetMe)
marked this pull request as ready for review
November 14, 2019 15:43
Mathias R. Jessen (IISResetMe)
requested a review
from Dongbo Wang (daxian-dbw)
as a code owner
November 14, 2019 15:43
Mathias R. Jessen (IISResetMe)
added a commit
to IISResetMe/EditorSyntax
that referenced
this pull request
Nov 16, 2019
To reflect changes to binary comparison operators in PowerShell/PowerShell#11068
Collaborator
|
RE: The additional questions -- yes, I'd say it's worth including the negative versions, but I don't see a lot of value in a case-sensitive version, since folx can just use case-sensitive operators inside the scriptblock expression to get the same effect. |
Rain Sallow (/u/ta11ow) (vexx32)
suggested changes
Nov 18, 2019
Rain Sallow (/u/ta11ow) (vexx32)
left a comment
Collaborator
There was a problem hiding this comment.
Looks lovely overall!
Couple minor thoughts in a few parts, but other than that this is good to go imo! 💖
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Mathias R. Jessen (IISResetMe)
force-pushed
the
feature/any-all-lambda7
branch
from
October 13, 2020 21:17
8b0da2a to
e60f1d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request adds 2 new containment operators:
-any(ex.1..5 -any { $_ -eq 2 })lhsoperand and a predicate as itsrhsoperand. Returnstrueif the predicate istruefor any lhs value, returnsfalseotherwise-all(ex.1..5 -all { $_ -gt 0 })trueif the predicate istruefor all lhs value, returnsfalseotherwiseIf a non-delegate-like object is passed as the
rhsoperand, we perform a scalar equality comparison against each item inlhs.A related update to the EditorSyntax definition has been prepared here: PowerShell/EditorSyntax#189
PR Context
This PR is partly motivated by the discussion in #7925, and my own frustration with having to cast nested loop structures to perform similar containment testing.
For example, to find a directory in which all files a marked
hidden:(I'm aware that dynamic parameter aliases exist specifically for attribute filtering in the FileSystem provider, but that's sort of missing the point,
-any/-allwould work in any context)TODO:
-notany/-noneand-notall)-containsfallback edge case)PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.