Skip to content

Group-Object - Use Case-Sensitive Hashtable for -CaseSensitive -AsHashtable #11030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Nov 13, 2019
Merged

Group-Object - Use Case-Sensitive Hashtable for -CaseSensitive -AsHashtable #11030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e5af52
:sparkles: :white_check_mark: Add case sensitivity
vexx32 Nov 10, 2019
1e51050
:recycle: Refactor GroupObjectCommand
vexx32 Nov 10, 2019
c307f2e
:white_check_mark: Update tests
vexx32 Nov 10, 2019
f4ad672
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Obj…
vexx32 Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/Group-Object.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,9 +516,12 @@ protected override void EndProcessing()
s_tracer.WriteLine(_groups.Count);
if (_groups.Count > 0)
{
if (AsHashTable)
if (AsHashTable.IsPresent)
{
Hashtable hashtable = CollectionsUtil.CreateCaseInsensitiveHashtable();
StringComparer comparer = CaseSensitive.IsPresent
? StringComparer.CurrentCulture
: StringComparer.CurrentCultureIgnoreCase;
var hashtable = new Hashtable(comparer);
try
{
if (AsString)
Expand Down
17 changes: 16 additions & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Object.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,21 @@ Describe "Check 'Culture' parameter in order object cmdlets (Group-Object, Sort-
$testCulture = "1049"
}

{$testObject | Group-Object -Culture $testCulture } | Should -Not -Throw
{ $testObject | Group-Object -Culture $testCulture } | Should -Not -Throw
}

It 'should not throw a key duplication error with -CaseSensitive -AsHashtable' {
$capitonyms = @(
[PSCustomObject]@{
Capitonym = 'Bill'
}
[PSCustomObject]@{
Capitonym = 'bill'
}
)

$Result = $capitonyms | Group-Object -Property Capitonym -AsHashTable -CaseSensitive
$Result | Should -BeOfType [HashTable]
$Result.Keys | Should -BeIn @( 'Bill', 'bill' )
}
}