Skip to content

Fix piping more than one CommandInfo to Get-Command #10929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 2 commits into from
Nov 7, 2019
Merged

Fix piping more than one CommandInfo to Get-Command #10929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d946a11
Fix piping more than one COmmandInfo to Get-Command
SteveL-MSFT Oct 29, 2019
69b6692
Update test/powershell/Modules/Microsoft.PowerShell.Core/Get-Command.…
SteveL-MSFT Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/System.Management.Automation/engine/GetCommandCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,8 @@ protected override void BeginProcessing()
/// </summary>
Comment thread
SteveL-MSFT marked this conversation as resolved.
protected override void ProcessRecord()
{
_commandsWritten.Clear();

// Module and FullyQualifiedModule should not be specified at the same time.
// Throw out terminating error if this is the case.
if (_isModuleSpecified && _isFullyQualifiedModuleSpecified)
Expand Down
6 changes: 6 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Core/Get-Command.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,4 +263,10 @@ Describe "Get-Command Tests" -Tags "CI" {
VerifyDynamicParametersExist -cmdlet $results[0] -parameterNames $paramName
VerifyParameterType -cmdlet $results[0] -parameterName $paramName -ParameterType System.Text.Encoding
}

It "Piping more than one CommandInfo works" {
$result = Get-Command -Name Add-Content, Get-Content | Get-Command
$result.Count | Should -Be 2
$result.Name | Should -Be "Add-Content","Get-Content"
}
}