Skip to content

Fix stringdata test to correctly validate keys of hashtables #10810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Oct 23, 2019
Merged

Fix stringdata test to correctly validate keys of hashtables #10810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ bazz = 2
Describe "Delimiter parameter tests" -Tags "CI" {
Comment thread
SteveL-MSFT marked this conversation as resolved.
Outdated
BeforeAll {
$TestCases = @(
@{ Delimiter = ':'; StringData = 'value:10'; ExpectedResult = @{ Values = 10 } }
@{ Delimiter = '-'; StringData = 'a-b' ; ExpectedResult = @{ Values = 'b' } }
@{ Delimiter = ','; StringData = 'c,d' ; ExpectedResult = @{ Values = 'd' } }
@{ Delimiter = ':'; StringData = 'value:10'; ExpectedResult = @{ value = 10 } }
@{ Delimiter = '-'; StringData = 'a-b' ; ExpectedResult = @{ a = 'b' } }
@{ Delimiter = ','; StringData = 'c,d' ; ExpectedResult = @{ c = 'd' } }
)
}

Expand All @@ -89,14 +89,17 @@ a:b
{ $sampleData | ConvertFrom-StringData -Delimiter ':' } | Should -Not -Throw
}

It 'is able to parse <StringData> with delimiter "<Delimiter>"' -TestCases $TestCases {
It 'is able to parse <StringData> with delimiter "<Delimiter> with <stringdata>"' -TestCases $TestCases {
param($Delimiter, $StringData, $ExpectedResult)

$Result = ConvertFrom-StringData -StringData $StringData -Delimiter $Delimiter

foreach ($Key in $ExpectedResult.Keys) {
$Key | Should -BeIn $ExpectedResult.Keys
$Result.$Key | Should -Be $ExpectedResult.$Key
}
$key = $ExpectedResult.Keys
Comment thread
SteveL-MSFT marked this conversation as resolved.
Outdated

# validate the key in expected and result hashtables match
$Result.Keys | Should -BeExactly $ExpectedResult.Keys

# validate the values in expected and result hashtables match
$Result[$key] | Should -BeExactly $ExpectedResult.Values
}
}