Skip to content

Add test for the even handler leaking fix #10768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Oct 11, 2019
Merged

Add test for the even handler leaking fix #10768

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3029b00
Add test for the handler leaking fix
daxian-dbw Oct 10, 2019
547584f
Fix comment
daxian-dbw Oct 10, 2019
6bc7e2a
Fix CodeFactor issues
daxian-dbw Oct 10, 2019
0ab5c5a
Skip the test on non-windows
daxian-dbw Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion test/xUnit/csharp/test_Runspace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
// Licensed under the MIT License.
Comment thread
daxian-dbw marked this conversation as resolved.

using System;
using System.Collections.Generic;
using System.Management.Automation;
using System.Management.Automation.Runspaces;
using System.Reflection;
using Xunit;

namespace PSTests.Sequential
Expand Down Expand Up @@ -101,5 +101,29 @@ public void TestRunspaceWithPowerShellAndInitialSessionState()
runspace.Close();
}
}

[SkippableFact]
public void TestAppDomainProcessExitEvenHandlerNotLeaking()
{
Skip.IfNot(Platform.IsWindows);

EventHandler eventHandler;
Delegate[] delegates;
FieldInfo field = typeof(AppContext).GetField("ProcessExit", BindingFlags.NonPublic | BindingFlags.Static);

// Open runspace and invoke script.
using (var ps = PowerShell.Create())
{
ps.AddScript("1").Invoke();
eventHandler = (EventHandler)field.GetValue(null);
delegates = eventHandler.GetInvocationList();
Assert.Contains(delegates, d => d.Method.Name == "CurrentDomain_ProcessExit");
}

// Handler registered by PowerShell should be unregistered.
eventHandler = (EventHandler)field.GetValue(null);
delegates = eventHandler.GetInvocationList();
Assert.DoesNotContain(delegates, d => d.Method.Name == "CurrentDomain_ProcessExit");
}
}
}