Rename Copy.Item.Tests.ps1 to match naming convention - #10701
Conversation
|
We have many files not matching naming convention. |
|
I agree completely. However we cant just fix everything all at once.. That's why we need the approach fix it when you see it. :) |
|
Mm true. I could see fixing the naming on each file in a given folder, doing it one folder at a time, perhaps? |
|
I don't see a value from the change because we use modern IDEs with power and fast search, c# plugins allows us to follow by references, also sometimes we have many classes in one file - as result file name lost value but in the same time renaming complicates commit history. |
I kinda agree with Ilya (@iSazonov) on that. Renaming a file will cause the file history to be "lost" (or to be more accurate, harder to retrieve). So if it's not necessary, maybe we should avoid renaming files. |
|
Is it so frequent that we need to dig up file history? The additional time needed to dig up file history is usually not immense, and not needed very often. I would be surprised if that's necessary anywhere near as much as folx need to go looking for the file. Time lost finding the file as it is now v.s. time lost finding the file as it was before the rename weighted depending on frequency of need. I would argue that having a consistent naming convention will make maintenance easier both for the PS team and folx in the community, especially folx just starting to look at contributing. In my opinion the consistency is valuable here, but y'all may have different ideas. 🙂 |
If you want to get better understanding how a code works you will look history frequently. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
e878672 to
59f0f41
Compare
Dongbo Wang (daxian-dbw)
left a comment
There was a problem hiding this comment.
Conflicts resolved.
romero126 Sorry that this PR has been overlooked for so long ...
The general guideline is to avoid renaming files to keep the history handy. But in this particular case, the history is not very interesting. So I decide to take this change.
|
The change in this PR has nothing to do with the CI failure, so I will force merge it. |
|
🎉 Handy links: |
PR Summary
Rename Copy.Item.Tests.ps1 -> Copy-Item.Tests.ps1
in order to match naming convention inside \test\powershell\Modules\Microsoft.PowerShell.Management
PR Context
All filenames in \test\powershell\Modules\Microsoft.PowerShell.Management use Verb-Command.Tests when naming their files. This one however does not match that standard.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.