Skip to content

Fix 38 failing AppVeyor tests #488

Closed

Description

A lot of these fail with "The handle is invalid".

Activity

  1. added this to the milestone on Feb 4, 2016
  2. changed the title [-]FIx 38 failing Windows tests[/-] [+]Fix 38 failing Windows tests[/+] on Feb 5, 2016
  3. andyleejordan commented on Feb 5, 2016

    @andyleejordan
    MemberAuthor

    36 of these don't fail locally. Only two fail with .\bin\powershell.exe --noprofile -c "invoke-pester test/powershell".

  4. andyleejordan commented on Feb 5, 2016

    @andyleejordan
    MemberAuthor

    I think we still need to solve the interactivity problem, which we may want to put off until after #495.

  5. palladia commented on Feb 5, 2016

    @palladia
    Contributor

    See my PR

  6. andyleejordan commented on Feb 5, 2016

    @andyleejordan
    MemberAuthor

    George Fleming (@palladia) you have the same tests failing.

    Do you have zero failing locally?

  7. palladia commented on Feb 5, 2016

    @palladia
    Contributor

    I am getting no failure on both Windows and Linux.

    From: Andy Schwartzmeyer [mailto:notifications@github.com]
    Sent: Friday, February 5, 2016 3:23 PM
    To: PowerShell/PowerShell PowerShell@noreply.github.com
    Cc: George Fleming (Insight Global) v-geflem@microsoft.com
    Subject: Re: [PowerShell] Fix 38 failing Windows tests (#488)

    @palladiahttps://github.com/palladia you have the same tests failinghttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.appveyor.com%2fproject%2fPowerShell%2fpowershell-linux%2fbuild%2f1.0.160%23L2521&data=01%7c01%7cv-geflem%40microsoft.com%7cf840eee37a2941ceb33108d32e835b6b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=t2cvCQWWR9rF6wg60hLYLZ1bnoJh6kEtH%2fcyGRJ1V8o%3d.

    Do you have zero failing locally?

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/488#issuecomment-180618442.

  8. palladia commented on Feb 5, 2016

    @palladia
    Contributor

    Can’t see your failures, as I have no AppVeyor access.

    From: Andy Schwartzmeyer [mailto:notifications@github.com]
    Sent: Friday, February 5, 2016 3:23 PM
    To: PowerShell/PowerShell PowerShell@noreply.github.com
    Cc: George Fleming (Insight Global) v-geflem@microsoft.com
    Subject: Re: [PowerShell] Fix 38 failing Windows tests (#488)

    @palladiahttps://github.com/palladia you have the same tests failinghttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.appveyor.com%2fproject%2fPowerShell%2fpowershell-linux%2fbuild%2f1.0.160%23L2521&data=01%7c01%7cv-geflem%40microsoft.com%7cf840eee37a2941ceb33108d32e835b6b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=t2cvCQWWR9rF6wg60hLYLZ1bnoJh6kEtH%2fcyGRJ1V8o%3d.

    Do you have zero failing locally?

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/488#issuecomment-180618442.

  9. andyleejordan commented on Feb 5, 2016

    @andyleejordan
    MemberAuthor

    Yes you do. You need to login to AppVeyor with your GitHub account and choose the PowerShell organization.

  10. palladia commented on Feb 5, 2016

    @palladia
    Contributor

    Logged in, but haven’t figured out how to add PowerShell org. Which tests were failing?

    From: Andy Schwartzmeyer [mailto:notifications@github.com]
    Sent: Friday, February 5, 2016 3:36 PM
    To: PowerShell/PowerShell PowerShell@noreply.github.com
    Cc: George Fleming (Insight Global) v-geflem@microsoft.com
    Subject: Re: [PowerShell] Fix 38 failing Windows tests (#488)

    Yes you do. You need to login to AppVeyor with your GitHub account and choose the PowerShell organization.

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/488#issuecomment-180622737.

  11. andyleejordan commented on Feb 5, 2016

    @andyleejordan
    MemberAuthor

    You need to figure out how to view the AppVeyor results.

    There are consistently just shy of 40 tests failing with the error "The handle is invalid" as documented in this issue, and I don't believe we can fix this without some serious work in the host, which should probably not happen because of this comment.

  12. changed the title [-]Fix 38 failing Windows tests[/-] [+]Fix 38 failing AppVeyor tests[/+] on Feb 8, 2016
  13. palladia commented on Feb 11, 2016

    @palladia
    Contributor

    On my Windows CoreCLR build, I get no error if I run the powershell command from "cmd", but same 36 errors if I run from the git-bash shell.

    So I been testing using the git-bash shell, and I see this interesting dump:

    $ ./bin/powershell.exe --noprofile -c "gcm"
    
    Unhandled Exception: System.Management.Automation.CmdletInvocationException: The handle is invalid ---> System.IO.IOException: The handle is invalid
       at System.ConsolePal.GetBufferInfo(Boolean throwOnNoConsole, Boolean& succeeded)
       at System.Console.get_BufferWidth()
       at Microsoft.PowerShell.Linux.Host.MyRawUserInterface.get_BufferSize()
       at System.Management.Automation.Internal.Host.InternalHostRawUserInterface.get_BufferSize()
       at Microsoft.PowerShell.Commands.Internal.Format.ConsoleLineOutput.get_ColumnNumber()
       at Microsoft.PowerShell.Commands.Internal.Format.ConsoleLineOutput.WriteLine(String s)
       at Microsoft.PowerShell.Commands.Internal.Format.OutCommandInner.ProcessFormatStart(OutputContext c)
       at Microsoft.PowerShell.Commands.Internal.Format.FormatMessagesContextManager.Process(Object o)
       at Microsoft.PowerShell.Commands.Internal.Format.OutCommandInner.ProcessObject(PSObject so)
       at Microsoft.PowerShell.Commands.Internal.Format.OutCommandInner.ProcessRecord()
       at Microsoft.PowerShell.Commands.Internal.Format.FrontEndCommandBase.ProcessRecord()
       at System.Management.Automation.Cmdlet.DoProcessRecord()
       at System.Management.Automation.CommandProcessor.ProcessRecord()
       --- End of inner exception stack trace ---
       at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
       at System.Management.Automation.Runspaces.Pipeline.Invoke()
       at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
       at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
       at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
       at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
       at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
       at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
       at Microsoft.PowerShell.Linux.Host.Listener.ExecuteHelper(String cmd, Object input)
       at Microsoft.PowerShell.Linux.Host.Listener..ctor(String initialScript, Boolean loadProfiles)
       at Microsoft.PowerShell.Linux.Host.Program.Main(String[] args)
    
    v-geflem@MININT-88MISUS MINGW64 ~/Desktop/test/PowerShell (master)
    
  14. andyleejordan commented on Feb 11, 2016

    @andyleejordan
    MemberAuthor

    This sample is where our entire host implemenation came from.

  15. andyleejordan commented on Feb 11, 2016

    @andyleejordan
    MemberAuthor

    George Fleming (@palladia) I edited your comment so that GitHub recognizes the issue reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions