Enable CA1852: Seal internal types

xtqqczze · xtqqczze · commit ea672693ad3b · 2025-08-25T10:50:10.000+01:00
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852 Fix #24094.
diff --git a/.globalconfig b/.globalconfig
@@ -510,6 +510,10 @@ dotnet_diagnostic.CA1846.severity = warning
 # https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847
 dotnet_diagnostic.CA1847.severity = warning
 
+# CA1852: Seal internal types
+# https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852
+dotnet_diagnostic.CA1852.severity = warning
+
 # CA1868: Unnecessary call to 'Contains' for sets
 # https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1868
 dotnet_diagnostic.CA1868.severity = warning
diff --git a/src/Microsoft.PowerShell.Commands.Diagnostics/NewWinEventCommand.cs b/src/Microsoft.PowerShell.Commands.Diagnostics/NewWinEventCommand.cs
@@ -323,7 +323,7 @@ protected override void EndProcessing()
         }
     }
 
-    internal class EventWriteException : Exception
+    internal sealed class EventWriteException : Exception
     {
         internal EventWriteException(string msg, Exception innerException)
             : base(msg, innerException)
diff --git a/src/Microsoft.PowerShell.Commands.Diagnostics/PdhHelper.cs b/src/Microsoft.PowerShell.Commands.Diagnostics/PdhHelper.cs
@@ -190,7 +190,7 @@ internal struct CounterHandleNInstance
         public string InstanceName;
     }
 
-    internal class PdhHelper : IDisposable
+    internal sealed class PdhHelper : IDisposable
     {
         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]
         private struct PDH_COUNTER_PATH_ELEMENTS
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/GetComputerInfoCommand.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/GetComputerInfoCommand.cs
@@ -1486,7 +1486,7 @@ public PowerManagementCapabilities[] GetPowerManagementCapabilities()
     }
 
     [SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Class is instantiated directly from a CIM instance")]
-    internal class WmiDeviceGuard
+    internal sealed class WmiDeviceGuard
     {
         public uint[] AvailableSecurityProperties;
         public uint? CodeIntegrityPolicyEnforcementStatus;
@@ -1595,7 +1595,7 @@ internal class WMiLogicalMemory
     }
 
     [SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Class is instantiated directly from a CIM instance")]
-    internal class WmiMsftNetAdapter
+    internal sealed class WmiMsftNetAdapter
     {
         public string Caption;
         public string Description;
@@ -1683,7 +1683,7 @@ internal class WmiMsftNetAdapter
     }
 
     [SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Class is instantiated directly from a CIM instance")]
-    internal class WmiNetworkAdapter
+    internal sealed class WmiNetworkAdapter
     {
         public string AdapterType;
         public ushort? AdapterTypeID;
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
@@ -2840,7 +2840,7 @@ internal struct PROCESS_INFORMATION
         }
 
         [StructLayout(LayoutKind.Sequential)]
-        internal class SECURITY_ATTRIBUTES
+        internal sealed class SECURITY_ATTRIBUTES
         {
             public int nLength;
             public SafeLocalMemHandle lpSecurityDescriptor;
diff --git a/src/Microsoft.WSMan.Management/CurrentConfigurations.cs b/src/Microsoft.WSMan.Management/CurrentConfigurations.cs
@@ -11,7 +11,7 @@ namespace Microsoft.WSMan.Management
     /// Class that queries the server and gets current configurations.
     /// Also provides a generic way to update the configurations.
     /// </summary>
-    internal class CurrentConfigurations
+    internal sealed class CurrentConfigurations
     {
         /// <summary>
         /// Prefix used to add NameSpace of root element to namespace manager.
diff --git a/src/Microsoft.WSMan.Management/WsManHelper.cs b/src/Microsoft.WSMan.Management/WsManHelper.cs
@@ -22,7 +22,7 @@
 namespace Microsoft.WSMan.Management
 {
     [SuppressMessage("Microsoft.Design", "CA1054:UriParametersShouldNotBeStrings", MessageId = "0#")]
-    internal class WSManHelper
+    internal sealed class WSManHelper
     {
         // regular expressions
         private const string PTRN_URI_LAST = @"([a-z_][-a-z0-9._]*)$";
@@ -89,7 +89,7 @@ internal class WSManHelper
         //
         //
         // Below class is just a static container which would release sessions in case this DLL is unloaded.
-        internal class Sessions
+        internal sealed class Sessions
         {
             /// <summary>
             /// Dictionary object to store the connection.

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ protected override void EndProcessing()`
`323`	`323`	`}`
`324`	`324`	`}`
`325`	`325`
`326`		`- internal class EventWriteException : Exception`
	`326`	`+ internal sealed class EventWriteException : Exception`
`327`	`327`	`{`
`328`	`328`	`internal EventWriteException(string msg, Exception innerException)`
`329`	`329`	`: base(msg, innerException)`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ internal struct CounterHandleNInstance`
`190`	`190`	`public string InstanceName;`
`191`	`191`	`}`
`192`	`192`
`193`		`- internal class PdhHelper : IDisposable`
	`193`	`+ internal sealed class PdhHelper : IDisposable`
`194`	`194`	`{`
`195`	`195`	`[StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]`
`196`	`196`	`private struct PDH_COUNTER_PATH_ELEMENTS`
Original file line number	Diff line number	Diff line change
`@@ -1486,7 +1486,7 @@ public PowerManagementCapabilities[] GetPowerManagementCapabilities()`
`1486`	`1486`	`}`
`1487`	`1487`
`1488`	`1488`	`[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Class is instantiated directly from a CIM instance")]`
`1489`		`- internal class WmiDeviceGuard`
	`1489`	`+ internal sealed class WmiDeviceGuard`
`1490`	`1490`	`{`
`1491`	`1491`	`public uint[] AvailableSecurityProperties;`
`1492`	`1492`	`public uint? CodeIntegrityPolicyEnforcementStatus;`
`@@ -1595,7 +1595,7 @@ internal class WMiLogicalMemory`
`1595`	`1595`	`}`
`1596`	`1596`
`1597`	`1597`	`[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Class is instantiated directly from a CIM instance")]`
`1598`		`- internal class WmiMsftNetAdapter`
	`1598`	`+ internal sealed class WmiMsftNetAdapter`
`1599`	`1599`	`{`
`1600`	`1600`	`public string Caption;`
`1601`	`1601`	`public string Description;`
`@@ -1683,7 +1683,7 @@ internal class WmiMsftNetAdapter`
`1683`	`1683`	`}`
`1684`	`1684`
`1685`	`1685`	`[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Class is instantiated directly from a CIM instance")]`
`1686`		`- internal class WmiNetworkAdapter`
	`1686`	`+ internal sealed class WmiNetworkAdapter`
`1687`	`1687`	`{`
`1688`	`1688`	`public string AdapterType;`
`1689`	`1689`	`public ushort? AdapterTypeID;`
Original file line number	Diff line number	Diff line change
`@@ -2840,7 +2840,7 @@ internal struct PROCESS_INFORMATION`
`2840`	`2840`	`}`
`2841`	`2841`
`2842`	`2842`	`[StructLayout(LayoutKind.Sequential)]`
`2843`		`- internal class SECURITY_ATTRIBUTES`
	`2843`	`+ internal sealed class SECURITY_ATTRIBUTES`
`2844`	`2844`	`{`
`2845`	`2845`	`public int nLength;`
`2846`	`2846`	`public SafeLocalMemHandle lpSecurityDescriptor;`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace Microsoft.WSMan.Management`
`11`	`11`	`/// Class that queries the server and gets current configurations.`
`12`	`12`	`/// Also provides a generic way to update the configurations.`
`13`	`13`	`/// </summary>`
`14`		`- internal class CurrentConfigurations`
	`14`	`+ internal sealed class CurrentConfigurations`
`15`	`15`	`{`
`16`	`16`	`/// <summary>`
`17`	`17`	`/// Prefix used to add NameSpace of root element to namespace manager.`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`namespace Microsoft.WSMan.Management`
`23`	`23`	`{`
`24`	`24`	`[SuppressMessage("Microsoft.Design", "CA1054:UriParametersShouldNotBeStrings", MessageId = "0#")]`
`25`		`- internal class WSManHelper`
	`25`	`+ internal sealed class WSManHelper`
`26`	`26`	`{`
`27`	`27`	`// regular expressions`
`28`	`28`	`private const string PTRN_URI_LAST = @"([a-z_][-a-z0-9._]*)$";`
`@@ -89,7 +89,7 @@ internal class WSManHelper`
`89`	`89`	`//`
`90`	`90`	`//`
`91`	`91`	`// Below class is just a static container which would release sessions in case this DLL is unloaded.`
`92`		`- internal class Sessions`
	`92`	`+ internal sealed class Sessions`
`93`	`93`	`{`
`94`	`94`	`/// <summary>`
`95`	`95`	`/// Dictionary object to store the connection.`