Skip to content

Commit 5b72eb5

Browse files
authored
Seal internal types in Microsoft.PowerShell.Commands.Utility (#25892)
1 parent 781c9a5 commit 5b72eb5

24 files changed

+36
-37
lines changed

src/Microsoft.PowerShell.Commands.Utility/commands/utility/ConvertTo-Html.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ internal static class ConvertHTMLParameterDefinitionKeys
321321
/// <summary>
322322
/// This allows for @{e='foo';label='bar';alignment='center';width='20'}.
323323
/// </summary>
324-
internal class ConvertHTMLExpressionParameterDefinition : CommandParameterDefinition
324+
internal sealed class ConvertHTMLExpressionParameterDefinition : CommandParameterDefinition
325325
{
326326
protected override void SetEntries()
327327
{

src/Microsoft.PowerShell.Commands.Utility/commands/utility/Csv.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace Microsoft.PowerShell.Commands
88
/// <summary>
99
/// This class is used to parse CSV text.
1010
/// </summary>
11-
internal class CSVHelper
11+
internal sealed class CSVHelper
1212
{
1313
internal CSVHelper(char delimiter)
1414
{

src/Microsoft.PowerShell.Commands.Utility/commands/utility/CsvCommands.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -885,7 +885,7 @@ protected override void ProcessRecord()
885885
/// <summary>
886886
/// Helper class for Export-Csv and ConvertTo-Csv.
887887
/// </summary>
888-
internal class ExportCsvHelper : IDisposable
888+
internal sealed class ExportCsvHelper : IDisposable
889889
{
890890
private readonly char _delimiter;
891891
private readonly BaseCsvWritingCommand.QuoteKind _quoteKind;
@@ -1224,7 +1224,7 @@ public void Dispose()
12241224
/// <summary>
12251225
/// Helper class to import single CSV file.
12261226
/// </summary>
1227-
internal class ImportCsvHelper
1227+
internal sealed class ImportCsvHelper
12281228
{
12291229
#region constructor
12301230

src/Microsoft.PowerShell.Commands.Utility/commands/utility/CustomSerialization.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace System.Management.Automation
1414
/// <summary>
1515
/// This class provides functionality for serializing a PSObject.
1616
/// </summary>
17-
internal class CustomSerialization
17+
internal sealed class CustomSerialization
1818
{
1919
#region constructor
2020
/// <summary>
@@ -179,8 +179,7 @@ internal void Stop()
179179
/// <summary>
180180
/// This internal helper class provides methods for serializing mshObject.
181181
/// </summary>
182-
internal class
183-
CustomInternalSerializer
182+
internal sealed class CustomInternalSerializer
184183
{
185184
#region constructor
186185

src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/ExpressionColumnInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
namespace Microsoft.PowerShell.Commands
88
{
9-
internal class ExpressionColumnInfo : ColumnInfo
9+
internal sealed class ExpressionColumnInfo : ColumnInfo
1010
{
1111
private readonly PSPropertyExpression _expression;
1212

src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/HeaderInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
namespace Microsoft.PowerShell.Commands
99
{
10-
internal class HeaderInfo
10+
internal sealed class HeaderInfo
1111
{
1212
private readonly List<ColumnInfo> _columns = new();
1313

src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OriginalColumnInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
namespace Microsoft.PowerShell.Commands
1111
{
12-
internal class OriginalColumnInfo : ColumnInfo
12+
internal sealed class OriginalColumnInfo : ColumnInfo
1313
{
1414
private readonly string _liveObjectPropertyName;
1515
private readonly OutGridViewCommand _parentCmdlet;

src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ internal static GridHeader ConstructGridHeader(PSObject input, OutGridViewComman
323323
internal abstract void ProcessInputObject(PSObject input);
324324
}
325325

326-
internal class ScalarTypeHeader : GridHeader
326+
internal sealed class ScalarTypeHeader : GridHeader
327327
{
328328
private readonly Type _originalScalarType;
329329

@@ -349,7 +349,7 @@ internal override void ProcessInputObject(PSObject input)
349349
}
350350
}
351351

352-
internal class NonscalarTypeHeader : GridHeader
352+
internal sealed class NonscalarTypeHeader : GridHeader
353353
{
354354
private readonly AppliesTo _appliesTo = null;
355355

@@ -453,7 +453,7 @@ internal override void ProcessInputObject(PSObject input)
453453
}
454454
}
455455

456-
internal class HeteroTypeHeader : GridHeader
456+
internal sealed class HeteroTypeHeader : GridHeader
457457
{
458458
internal HeteroTypeHeader(OutGridViewCommand parentCmd, PSObject input) : base(parentCmd)
459459
{

src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutWindowProxy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
namespace Microsoft.PowerShell.Commands
1515
{
16-
internal class OutWindowProxy : IDisposable
16+
internal sealed class OutWindowProxy : IDisposable
1717
{
1818
private const string OutGridViewWindowClassName = "Microsoft.Management.UI.Internal.OutGridViewWindow";
1919
private const string OriginalTypePropertyName = "OriginalType";

src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/ScalarTypeColumnInfo.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
namespace Microsoft.PowerShell.Commands
88
{
9-
internal class ScalarTypeColumnInfo : ColumnInfo
9+
internal sealed class ScalarTypeColumnInfo : ColumnInfo
1010
{
1111
private readonly Type _type;
1212

@@ -29,7 +29,7 @@ internal override object GetValue(PSObject liveObject)
2929
}
3030
}
3131

32-
internal class TypeNameColumnInfo : ColumnInfo
32+
internal sealed class TypeNameColumnInfo : ColumnInfo
3333
{
3434
internal TypeNameColumnInfo(string staleObjectPropertyName, string displayName)
3535
: base(staleObjectPropertyName, displayName)
@@ -43,7 +43,7 @@ internal override object GetValue(PSObject liveObject)
4343
}
4444
}
4545

46-
internal class ToStringColumnInfo : ColumnInfo
46+
internal sealed class ToStringColumnInfo : ColumnInfo
4747
{
4848
private readonly OutGridViewCommand _parentCmdlet;
4949

@@ -60,7 +60,7 @@ internal override object GetValue(PSObject liveObject)
6060
}
6161
}
6262

63-
internal class IndexColumnInfo : ColumnInfo
63+
internal sealed class IndexColumnInfo : ColumnInfo
6464
{
6565
private int _index = 0;
6666

0 commit comments

Comments
 (0)