This repository was archived by the owner on Dec 8, 2021. It is now read-only.
Minor refactoring in docker build scripts#28
Merged
Merged
Conversation
3 tasks
adityapatwardhan
approved these changes
Dec 5, 2017
TravisEz13
approved these changes
Dec 5, 2017
| } | ||
|
|
||
| Write-Host "##vso[artifact.upload containerfolder=results;artifactname=$leafFileName]$FileName" | ||
| Write-Host "##vso[artifact.upload containerfolder=results;artifactname=$leafFileName]$fileName" |
Member
There was a problem hiding this comment.
can we update the container folder to be $Bucket?
Member
Author
There was a problem hiding this comment.
Updated. Use $Bucket instead.
TravisEz13
reviewed
Dec 6, 2017
|
|
||
| # Optional: the number of expected binaries from the build. | ||
| [Int]$BinariesExpected = -1 | ||
| [Int]$ArtifactsExpected = -1 |
Member
There was a problem hiding this comment.
This requires JSON changes. Make sure to update the VSCode repo
Member
Author
There was a problem hiding this comment.
The build.json file in vscode-powershell repo doesn't contain the BinariesExpected key.
Member
Author
|
@TravisEz13 Can you please take another look? |
Member
|
This change looks good. let me look at the other PR. |
TravisEz13
approved these changes
Dec 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some name changes, comment updates, and random fixes.