Skip to content

Fix a bug in tooltip rendering related to calculation of the tooltip height#3671

Merged
daxian-dbw merged 1 commit into
PowerShell:masterfrom
daxian-dbw:fix
May 3, 2023
Merged

Fix a bug in tooltip rendering related to calculation of the tooltip height#3671
daxian-dbw merged 1 commit into
PowerShell:masterfrom
daxian-dbw:fix

Conversation

@daxian-dbw

@daxian-dbw daxian-dbw commented May 3, 2023

Copy link
Copy Markdown
Member

PR Summary

Fix a bug in tooltip rendering related to calculation of the tooltip height.
The tooltip height calculation is wrong due to my mistake on the precedence order of the ternary operator, which resulted in the clearance of list view not work as expected.

Before:

image

After:

image

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 6b7c48a into PowerShell:master May 3, 2023
@daxian-dbw daxian-dbw deleted the fix branch May 3, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant