Remove async tests for parser (PowerShell#3119)

JamesWTruher · daxian-dbw · commit d801b75d353d · 2017-02-15T16:39:30.000-08:00
* Remove async tests for parser this is a fix for PowerShell#3069 This removes an attempt to work-around the issue of tests hanging on Travis-CI. * remove unneeded finally block
diff --git a/test/powershell/Language/LanguageTestSupport.psm1 b/test/powershell/Language/LanguageTestSupport.psm1
@@ -23,57 +23,18 @@ function Get-RuntimeError
 {
     [CmdletBinding()]
     param(
-        [Parameter(ValueFromPipeline=$True,Mandatory=$True)]
-        [string]$src,
-        [Parameter()]
-        [int]$Timeout = 0
+        [Parameter(ValueFromPipeline=$True,Mandatory=$True)][string]$src
     )
  
     $errors = $null
     try
     {
-        # some tests cannot be run in a isolated runspace
-        # easily because they require more than just a single
-        # execution
-        if ( $Timeout -eq 0 )
-        {
-            [scriptblock]::Create($src).Invoke() > $null
-        }
-        else
-        {
-            $ps = [powershell]::Create()
-            $ps.AddScript($src) > $null
-            $ar = $ps.BeginInvoke()
-            # give it 250 milliseconds to complete
-            start-sleep -mill 250
-            if ( $ar.IsCompleted ) {
-                $ps.EndInvoke($ar)
-            }
-            # wait another ${Timeout} seconds, then give up
-            else {
-                Start-Sleep -sec $Timeout
-                if ( $ar.IsCompleted ) {
-                    # this can throw, which will be picked up below
-                    $ps.EndInvoke($ar)
-                }
-                else {
-                    # if it didn't throw, then return a constructed error
-                    $ER = Write-Error "Operation Timed Out ('$src')" 2>&1
-                    return $ER
-                }
-            }
-        }
+        [scriptblock]::Create($src).Invoke() > $null
     }
     catch
     {
         return $_.Exception.InnerException.ErrorRecord
     }
-    finally
-    {
-        if ( $ps -ne $null ) {
-            $ps.dispose()
-        }
-    }
 }
 
 function position_message
@@ -114,7 +75,7 @@ function ShouldBeParseError
         if ($SkipAndCheckRuntimeError)
         {
             It "error should happen at parse time, not at runtime" -Skip {}
-            $errors = Get-RuntimeError -Src $src -Timeout 10
+            $errors = Get-RuntimeError -Src $src
             # for runtime errors we will only get the first one
             $expectedErrors = ,$expectedErrors[0]
             $expectedOffsets = ,$expectedOffsets[0]
