[Bugs] Check incident status before re-adding IC (Netflix#4582)

jschroth · web-flow · commit 7178318e1251 · 2024-04-03T22:59:02.000-07:00
If an incident is closed, we expect the incident conversation to be closed as well. This will cause errors in slack, if we try to add someone to an archived conversation and send a message to that archived conversation.
diff --git a/src/dispatch/incident/flows.py b/src/dispatch/incident/flows.py
@@ -1028,7 +1028,7 @@ def incident_remove_participant_flow(
 
                     return
 
-    if user_email == incident.commander.individual.email:
+    if incident.status != IncidentStatus.closed and user_email == incident.commander.individual.email:
         # we add the participant to the conversation
         conversation_flows.add_incident_participants(
             incident=incident, participant_emails=[user_email], db_session=db_session
