[Bug] moved participant lookup (Netflix#4581)

jschroth · web-flow · commit 19b1774dd9f1 · 2024-04-03T22:41:30.000-07:00
Moved participant lookup to occur only if it is not archived because the participants will only be added if it is not archived.
diff --git a/src/dispatch/plugins/dispatch_slack/plugin.py b/src/dispatch/plugins/dispatch_slack/plugin.py
@@ -273,12 +273,11 @@ def send_ephemeral(
             send_ephemeral_message(client, conversation_id, user_id, text, blocks)
 
     def add(self, conversation_id: str, participants: List[str]):
-        """Adds users to conversation."""
+        """Adds users to conversation if it is not archived."""
         client = create_slack_client(self.configuration)
-        participants = [resolve_user(client, p)["id"] for p in set(participants)]
-
         archived = conversation_archived(client, conversation_id)
         if not archived:
+            participants = [resolve_user(client, p)["id"] for p in set(participants)]
             add_users_to_conversation(client, conversation_id, participants)
 
     def add_to_thread(self, conversation_id: str, thread_id: str, participants: List[str]):
