Skip to content

Protect readLine() against DoS #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pixeebot wants to merge 1 commit into from
Closed

Protect readLine() against DoS #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flow-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,10 @@
<version>${hibernate.validator.version}</version>
<scope>test</scope>
</dependency>

<dependency>

@pixeebot pixeebot Bot Jul 29, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library holds security tools for protecting Java API calls.

License: MIT ✅ | Open source ✅ | More facts

<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
</dependency>
</dependencies>
<build>
<resources>
Expand Down
3 changes: 2 additions & 1 deletion flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunDevBundleBuild.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.vaadin.flow.server.frontend;

import io.github.pixee.security.BoundedLineReader;
import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -173,7 +174,7 @@ private void runFrontendBuildTool(String toolName, String executable,
new InputStreamReader(process.getInputStream(),
StandardCharsets.UTF_8))) {
String stdoutLine;
while ((stdoutLine = reader.readLine()) != null) {
while ((stdoutLine = BoundedLineReader.readLine(reader, 5_000_000)) != null) {
logger.debug(stdoutLine);
toolOutput.append(stdoutLine)
.append(System.lineSeparator());
Expand Down
4 changes: 4 additions & 0 deletions flow-test-util/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>
<dependency>

@pixeebot pixeebot Bot Jul 29, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library holds security tools for protecting Java API calls.

License: MIT ✅ | Open source ✅ | More facts

<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
</dependency>
</dependencies>

<build>
Expand Down
3 changes: 2 additions & 1 deletion ...test-util/src/main/java/com/vaadin/flow/testutil/net/LinuxEphemeralPortRangeDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// under the License.
package com.vaadin.flow.testutil.net;

import io.github.pixee.security.BoundedLineReader;
import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -65,7 +66,7 @@ public static LinuxEphemeralPortRangeDetector getInstance() {
int lowPort = defaultRange.getLowestEphemeralPort();
int highPort = defaultRange.getHighestEphemeralPort();
try (BufferedReader in = new BufferedReader(inputFil)) {
String[] split = in.readLine().split("\\s+", 3);
String[] split = BoundedLineReader.readLine(in, 5_000_000).split("\\s+", 3);
lowPort = Integer.parseInt(split[0]);
highPort = Integer.parseInt(split[1]);
} catch (IOException | NullPointerException ignore) {
Expand Down
7 changes: 7 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@
<failsafe.parallel>all</failsafe.parallel>
<failsafe.threadCount>2</failsafe.threadCount>
<failsafe.perCoreThreadCount>true</failsafe.perCoreThreadCount>
<versions.java-security-toolkit>1.2.1</versions.java-security-toolkit>
</properties>

<repositories>
Expand Down Expand Up @@ -280,6 +281,12 @@
<artifactId>hamcrest-all</artifactId>
<version>1.3</version>
</dependency>
<dependency>

@pixeebot pixeebot Bot Jul 29, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library holds security tools for protecting Java API calls.

License: MIT ✅ | Open source ✅ | More facts

<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>

@pixeebot pixeebot Bot Jul 29, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library holds security tools for protecting Java API calls.

License: MIT ✅ | Open source ✅ | More facts

<version>${versions.java-security-toolkit}</version>
</dependency>
</dependencies>
</dependencyManagement>

Expand Down
Loading