Merged
Conversation
22b050d to
de14436
Compare
Contributor
|
Add why we want to change these versions to the PR description please |
crschardt
reviewed
Jan 3, 2026
Member
Author
So that we bump everything to node 24? |
093426e to
40bce4c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0465786 to
bbec66f
Compare
2 tasks
7adadd0 to
f1032ac
Compare
243247c to
7c91524
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Gold856
reviewed
Jan 7, 2026
Gold856
approved these changes
Jan 7, 2026
This was referenced Jan 8, 2026
Gold856
added a commit
to PhotonVision/photon-libcamera-gl-driver
that referenced
this pull request
Jan 9, 2026
Resolves #19. Following PhotonVision/photonvision#2274, all actions have been updated to Node 24 versions. Uses the new platform path getter from the tool plugin. Removes test dependencies instead of updating them because there's no tests. Adds formatting checks to CI, updates wpiformat files, and removes old format.sh in favor of just using wpiformat. Also updates minimum CMake version to allow removing of hacky AWT dependency bypass for the JNI package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bumps our actions to versions that use Node 24, instead of 20. Node 20 enters EOL in April 2026.
This PR also includes various cleanups that should speed up CI, and make it less complicated. This includes removing the architecture field from setup-java, as it detects the native architecture.
We also upload our Gradle dependencies for charting in GitHub, this helps us keep track of what we're using, and if we need to upgrade.
Finally, we bump the version of our image, to fix issues with the Rubik Pi fan among other reasons.
continuation of #2194
supercedes #2276
Meta
Merge checklist: