Merged
Conversation
Currently metadata items are outputting a `time` element with a `datetime` attribute which is ISO 8601 compliant, but does not include information about time of day and timezone offset. This updates the output so it outputs all available information. Before: ```html <time class="icon-calendar pr20" datetime="2016-12-03" itemprop="datePublished">2016-12-03</time> ``` After ```html <time class="icon-calendar pr20" datetime="2016-12-03T08:00:00+08:00" itemprop="datePublished"> 2016-12-03</time> ``` References: http://devdocs.io/html/element/time for general info https://www.w3.org/TR/html51/infrastructure.html#dates-and-times for information about http://jekyll.tips/jekyll-cheat-sheet/ for liquid filter info
TWiStErRob
approved these changes
Mar 1, 2017
TWiStErRob
left a comment
Contributor
There was a problem hiding this comment.
Why are all your PRs conflicting?
Author
They were created using the in-browser editor and it decided to pull commits from my fork. |
rollingrock
pushed a commit
to rollingrock/joelucky
that referenced
this pull request
Aug 31, 2025
Use datetime for time element
benchoi93
pushed a commit
to choi-seongjin/choi-seongjin.github.io
that referenced
this pull request
Jun 7, 2026
Use datetime for time element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently metadata items are outputting a
timeelement with adatetimeattribute which is ISO 8601 compliant, but does not include information about time of day and timezone offset. This updates the output so it outputs all available information.Before:
After
References:
http://devdocs.io/html/element/time for general info
https://www.w3.org/TR/html51/infrastructure.html#dates-and-times for spec
http://jekyll.tips/jekyll-cheat-sheet/ for liquid filter info