Conversation
The changes in PR 923 did not take `foreach ( ...as list() ) {}` into account.
Fixed now. Includes unit test.
Fixes 928
Closes 929
…bidden-names-as-list
ForbiddenNames: allow for `foreach( ... as list() ) {}`
Includes adding missing milestone links for the 9.3.3 release.
Changelog for PHPCompatibility 9.3.4
wimg
approved these changes
Nov 15, 2019
Member
Author
|
Release tweet: https://twitter.com/jrf_nl/status/1195199999677751297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for tracking changes for the 9.3.4 release. Target release date: Friday November 15.
master(careful, GH defaults todevelop!) & copy & paste the changelog to itOpen PR to mergemasterintodevelopto get rid of the This branch is out-of-date with the base branch messages on each release. (only after major releases)