You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Most likely developers are adding features and testing in one browser. We should have an automated check to make sure the functionality is the same across browsers.
What should your feature do?
In a perfect world I would love to see something that upon a new PR (or update to a PR) looks at the files changed and attaches screenshots (or a link to screenshots) of the pages across the major mobile and desktop browsers. Does browserstack cover this or at least come close?
We still need more detail on how this is implemented. Ideally when a new PR comes in we would have browserstack run some tests/take some screenshots and report its status to said PR.
Do we have a testing framework in mind? Mocha maybe? I know jest is in there by default. I would like to use a good testing library that is easy to write.
No. We need the BrowserStack account information @hollomancer
Once acquired, we can draw up instructions on eyeballing certain browsers on a release basis. We can't exactly share our account out so I think drafting up this methodology is best. It's tough to automate this.
Activity
hollomancer commentedon Jun 8, 2017
Sauce Labs and Browserstack provide functionality like this.
rickr commentedon Jun 9, 2017
We now have a browserstack account.
We still need more detail on how this is implemented. Ideally when a new PR comes in we would have browserstack run some tests/take some screenshots and report its status to said PR.
sethbergman commentedon Aug 6, 2017
Do we have a testing framework in mind? Mocha maybe? I know jest is in there by default. I would like to use a good testing library that is easy to write.
Sent from my Samsung SM-S120VL using FastHub
hollomancer commentedon Oct 14, 2017
Now we just need someone to write some automated UI tests :)
kylemh commentedon Oct 22, 2017
#327 💃
kylemh commentedon Oct 22, 2017
As for resolving the issue, I think implementing some documentation on using Browser Stack would be good enough to close this.
dmarchante commentedon Aug 21, 2018
@kylemh can this be closed due to your testing implementation for the new repo?
kylemh commentedon Aug 22, 2018
No. We need the BrowserStack account information @hollomancer
Once acquired, we can draw up instructions on eyeballing certain browsers on a release basis. We can't exactly share our account out so I think drafting up this methodology is best. It's tough to automate this.
Merge pull request OperationCode#113 from OperationCode/chore/fix-con…