This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Repository navigation
Feature/104 user count by state - #109
Merged
Merged
Conversation
Collaborator
Author
|
@rickr - Travis is failing; however, when grepping for Can you determine if something is going on with the build, or? |
We use this logic now twice in user.rb. Adding it as a private method in the class triggered errors, and besides that, really was not a concern of user.rb. Abstracting this into a dedicated class for when we need to massage data, in future scenarios.
hpjaj
force-pushed
the
feature/104-user-count-by-state
branch
from
July 22, 2017 14:49
904f8d8 to
3922c89
Compare
When hitting the actual API it works, by during test runs, it is flaky.
Collaborator
Author
|
@rickr - this is happening again: Can you look into it? |
Contributor
|
I don't see any problems either. Are we mocking the call to the geocoding API? I wonder if we're getting rate limited? |
hpjaj
force-pushed
the
feature/104-user-count-by-state
branch
from
July 23, 2017 02:11
c09223d to
b717621
Compare
Collaborator
Author
|
@rickr - this one is ready |
rickr
approved these changes
Jul 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds ability to query by users'
:state's, to determine user count. Specifically:paramto theusers/by_locationaction called:statethat returns a count of the users in a particular state.Issue Resolved
Fixes #104