Skip to content

Add files via upload - #62

Closed
JanosBerke wants to merge 1 commit into
OpenQueryStore:masterfrom
JanosBerke:JanosBerke-patch-1
Closed

Add files via upload#62
JanosBerke wants to merge 1 commit into
OpenQueryStore:masterfrom
JanosBerke:JanosBerke-patch-1

Conversation

@JanosBerke

Copy link
Copy Markdown

upgrade to v2.1.0 from the previous release

upgrade to v2.1.0 from the previous release

@sql-williamd sql-williamd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this idea. We'd been thinking about how to implement this (or even if we should).

Enrico and I think it is probably easiest to create an upgrade file for each release, named for the release.

We are thinking of making a PowerShell upgrader (like the install and uninstall), which will deal with these files correctly.

For now, this is a great addition!

I've added thoughts/revision requests in this PR. If you have questions, just drop me a message here.

EXEC sys.sp_addextendedproperty @name=N'oqs_version', @value=N'2.1.0' , @level0type=N'SCHEMA',@level0name=N'oqs', @level1type=N'TABLE',@level1name=N'collection_metadata'
GO

DELETE FROM [oqs].[collection_metadata]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like to keep metadata between upgrades. Can you "archive" the settings before making the change, then re-insert them, adding the new column values to it. This way, OQS behaviour remains the same for a user between versions.

USE $(DatabaseWhereOQSIsRunning)
GO

ALTER TABLE [oqs].[collection_metadata]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the default idea here..... i think we should add that to the general installer.... (i've just made an issue for that reason)

[data_cleanup_threshold],
[data_cleanup_throttle]
)
VALUES ( N'EXEC [oqs].[gather_statistics] @logmode=1', 60 , '$(OQSMode)','$(DatabaseWhereOQSIsRunning)',1,2,0,30,5000);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the default constraints done on the entire table, we can just insert DEFAULT VALUES here. makes it cleaner.

@sql-williamd

Copy link
Copy Markdown
Collaborator

Things have moved on quite a bit since this PR was submitted. I'm closing this now, if you want to resubmit based on a newer version, please do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants