Adding support for X-RateLimit-Reset HTTP header#979
Closed
tandrup wants to merge 3 commits into
Closed
Conversation
kdavisk6
requested changes
May 28, 2019
kdavisk6
left a comment
Member
There was a problem hiding this comment.
I like the idea, however, it may not appropriate for this to be applied automatically for all users. My preference would be to include a new ErrorDecoder implementation specifically for this use case. This will accomplish two things:
- Provide support this use case for all users
- Allow users to choose when to enable this support.
Thoughts?
velo
requested changes
Oct 4, 2019
velo
left a comment
Member
There was a problem hiding this comment.
I like the change, just need to make it build on Travis
Member
|
The build for this PR is broken due to compilation errors. If you are still interested in submitting this change, please update this PR to allow the build to pass and we will accept it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some services use the
X-RateLimit-ResetHTTP header instead of theRetry-Afterheader. Try to parse both.