Skip to content

Testing feign-example-github jar - #953

Merged
velo merged 4 commits into
OpenFeign:masterfrom
velo:example
May 12, 2019
Merged

Testing feign-example-github jar #953
velo merged 4 commits into
OpenFeign:masterfrom
velo:example

Conversation

@velo

@velo velo commented May 3, 2019

Copy link
Copy Markdown
Member

No description provided.

@kdavisk6

kdavisk6 commented May 3, 2019

Copy link
Copy Markdown
Member

An integration test? I love it

@kdavisk6 kdavisk6 added this to the 10.3.0 milestone May 9, 2019
@kdavisk6

kdavisk6 commented May 9, 2019

Copy link
Copy Markdown
Member

@velo

Could we update the builds to call this manually instead of from Maven to reduce the chances of the API Rate Limit?

@kdavisk6 kdavisk6 added the chore For issues related to technical debt and other non-functional tasks label May 9, 2019
@velo

velo commented May 9, 2019

Copy link
Copy Markdown
Member Author

I wanna create an account and include auth so we have a higher rate limit.

but, you know, procrastinating is an art =)

Also, need to change packaging to try to reproduce the original issue that sparkled this change

@velo
velo force-pushed the example branch 2 times, most recently from 3f8a393 to 5502968 Compare May 10, 2019 22:01
@velo
velo force-pushed the example branch 2 times, most recently from 042a3e5 to fd22d1a Compare May 12, 2019 01:48
@velo
velo requested a review from kdavisk6 May 12, 2019 02:00
@velo velo added the ready to merge Will be merged if no other member ask for changes label May 12, 2019
@velo

velo commented May 12, 2019

Copy link
Copy Markdown
Member Author

@kdavisk6 added a new encrypted github token, now test works on travis

@velo
velo merged commit bf9d292 into OpenFeign:master May 12, 2019
@velo
velo deleted the example branch May 12, 2019 04:31
velo added a commit to velo/feign that referenced this pull request Jun 30, 2019
* Running GitHubExample as unit test

* Testing feign-example-github jar

* Rename packages to cross module boundary

* Adding github token
@kdavisk6 kdavisk6 removed this from the 10.4.0 milestone Aug 12, 2019
velo added a commit that referenced this pull request Oct 7, 2024
* Running GitHubExample as unit test

* Testing feign-example-github jar

* Rename packages to cross module boundary

* Adding github token
velo added a commit that referenced this pull request Oct 8, 2024
* Running GitHubExample as unit test

* Testing feign-example-github jar

* Rename packages to cross module boundary

* Adding github token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore For issues related to technical debt and other non-functional tasks ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants